mirror of
https://github.com/armbian/build
synced 2025-09-24 19:47:06 +07:00
Grab several patches from collabora and upstream
This commit is contained in:
File diff suppressed because it is too large
Load Diff
4362
patch/kernel/rockchip-rk3588-edge/0010-Introduce-RK806-Support.patch
Normal file
4362
patch/kernel/rockchip-rk3588-edge/0010-Introduce-RK806-Support.patch
Normal file
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,48 @@
|
||||
From 9572f9567627c5e80bf77248242ef2e5c90da600 Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Tue, 18 Apr 2023 16:21:09 +0200
|
||||
Subject: [PATCH 1/1] arm64: dts: rockchip: rk3588: add GIC ITS support
|
||||
|
||||
Add the two Interrupt Translation Service (ITS) IPs that are part of the
|
||||
GIC-600. They are mainly required for PCIe Message Signalled Interrupts
|
||||
(MSI).
|
||||
|
||||
Co-developed-by: Kever Yang <kever.yang@rock-chips.com>
|
||||
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 17 +++++++++++++++++
|
||||
1 file changed, 17 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index b46574358dd1..05af9a0fddf4 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -1688,7 +1688,24 @@ gic: interrupt-controller@fe600000 {
|
||||
mbi-alias = <0x0 0xfe610000>;
|
||||
mbi-ranges = <424 56>;
|
||||
msi-controller;
|
||||
+ ranges;
|
||||
+ #address-cells = <2>;
|
||||
#interrupt-cells = <4>;
|
||||
+ #size-cells = <2>;
|
||||
+
|
||||
+ its0: msi-controller@fe640000 {
|
||||
+ compatible = "arm,gic-v3-its";
|
||||
+ msi-controller;
|
||||
+ #msi-cells = <1>;
|
||||
+ reg = <0x0 0xfe640000 0x0 0x20000>;
|
||||
+ };
|
||||
+
|
||||
+ its1: msi-controller@fe660000 {
|
||||
+ compatible = "arm,gic-v3-its";
|
||||
+ msi-controller;
|
||||
+ #msi-cells = <1>;
|
||||
+ reg = <0x0 0xfe660000 0x0 0x20000>;
|
||||
+ };
|
||||
|
||||
ppi-partitions {
|
||||
ppi_partition0: interrupt-partition-0 {
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,36 @@
|
||||
From 0347eabc054a1253f481ab08cc683940cd048603 Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Mon, 3 Jul 2023 18:41:29 +0200
|
||||
Subject: [PATCH 1/1] irqchip/gic-v3: Enable Rockchip 3588001 erratum
|
||||
workaround for RK3588S
|
||||
|
||||
Commit a8707f553884 ("irqchip/gic-v3: Add Rockchip 3588001 erratum
|
||||
workaround") mentioned RK3588S (the slimmed down variant of RK3588)
|
||||
being affected, but did not check for its compatible value. Thus the
|
||||
quirk is not applied on RK3588S. Since the GIC ITS node got added to the
|
||||
upstream DT, boards using RK3588S are no longer booting without this
|
||||
quirk being applied.
|
||||
|
||||
Fixes: 06cdac8e8407 ("arm64: dts: rockchip: add GIC ITS support to rk3588")
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
drivers/irqchip/irq-gic-v3-its.c | 3 ++-
|
||||
1 file changed, 2 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
|
||||
index 0ec2b1e1df75..e14b10632257 100644
|
||||
--- a/drivers/irqchip/irq-gic-v3-its.c
|
||||
+++ b/drivers/irqchip/irq-gic-v3-its.c
|
||||
@@ -4725,7 +4725,8 @@ static bool __maybe_unused its_enable_rk3588001(void *data)
|
||||
{
|
||||
struct its_node *its = data;
|
||||
|
||||
- if (!of_machine_is_compatible("rockchip,rk3588"))
|
||||
+ if (!of_machine_is_compatible("rockchip,rk3588") &&
|
||||
+ !of_machine_is_compatible("rockchip,rk3588s"))
|
||||
return false;
|
||||
|
||||
its->flags |= ITS_FLAGS_FORCE_NON_SHAREABLE;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,57 @@
|
||||
From 0c7ec3f97f2dd703029b8a3250d04338623aea1a Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Thu, 18 May 2023 05:19:48 +0200
|
||||
Subject: [PATCH] clk: divider: Fix divisions
|
||||
|
||||
The clock framework handles clock rates as "unsigned long", so u32 on
|
||||
32-bit architectures and u64 on 64-bit architectures.
|
||||
|
||||
The current code pointlessly casts the dividend to u64 on 32-bit
|
||||
architectures and thus pointlessly reducing the performance.
|
||||
|
||||
On the other hand on 64-bit architectures the divisor is masked and only
|
||||
the lower 32-bit are used. Thus requesting a frequency >= 4.3GHz results
|
||||
in incorrect values. For example requesting 4300000000 (4.3 GHz) will
|
||||
effectively request ca. 5 MHz. Requesting clk_round_rate(clk, ULONG_MAX)
|
||||
is a bit of a special case, since that still returns correct values as
|
||||
long as the parent clock is below 8.5 GHz.
|
||||
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
drivers/clk/clk-divider.c | 6 +++---
|
||||
1 file changed, 3 insertions(+), 3 deletions(-)
|
||||
|
||||
diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
|
||||
index a2c2b5203b0a9..c38e8aa60e547 100644
|
||||
--- a/drivers/clk/clk-divider.c
|
||||
+++ b/drivers/clk/clk-divider.c
|
||||
@@ -220,7 +220,7 @@ static int _div_round_up(const struct clk_div_table *table,
|
||||
unsigned long parent_rate, unsigned long rate,
|
||||
unsigned long flags)
|
||||
{
|
||||
- int div = DIV_ROUND_UP_ULL((u64)parent_rate, rate);
|
||||
+ int div = DIV_ROUND_UP(parent_rate, rate);
|
||||
|
||||
if (flags & CLK_DIVIDER_POWER_OF_TWO)
|
||||
div = __roundup_pow_of_two(div);
|
||||
@@ -237,7 +237,7 @@ static int _div_round_closest(const struct clk_div_table *table,
|
||||
int up, down;
|
||||
unsigned long up_rate, down_rate;
|
||||
|
||||
- up = DIV_ROUND_UP_ULL((u64)parent_rate, rate);
|
||||
+ up = DIV_ROUND_UP(parent_rate, rate);
|
||||
down = parent_rate / rate;
|
||||
|
||||
if (flags & CLK_DIVIDER_POWER_OF_TWO) {
|
||||
@@ -473,7 +473,7 @@ int divider_get_val(unsigned long rate, unsigned long parent_rate,
|
||||
{
|
||||
unsigned int div, value;
|
||||
|
||||
- div = DIV_ROUND_UP_ULL((u64)parent_rate, rate);
|
||||
+ div = DIV_ROUND_UP(parent_rate, rate);
|
||||
|
||||
if (!_is_valid_div(table, div, flags))
|
||||
return -EINVAL;
|
||||
--
|
||||
GitLab
|
||||
|
||||
@@ -0,0 +1,266 @@
|
||||
From 9d842dbd76192184bd91f4a7abf57edc17ed5181 Mon Sep 17 00:00:00 2001
|
||||
From: Boris Brezillon <boris.brezillon@collabora.com>
|
||||
Date: Mon, 3 Apr 2023 21:32:50 +0200
|
||||
Subject: [PATCH 1/1] soc: rockchip: power-domain: add rk3588 mem module
|
||||
support
|
||||
|
||||
On RK3588 it's also possible to power down the memory used by the
|
||||
particular power domains via PMU_MEM_PWR_GATE_SFTCON. This adds
|
||||
support for this feature.
|
||||
|
||||
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
|
||||
Co-Developed-by: Finley Xiao <finley.xiao@rock-chips.com>
|
||||
Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
|
||||
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
drivers/soc/rockchip/pm_domains.c | 160 +++++++++++++++++++++++-------
|
||||
1 file changed, 125 insertions(+), 35 deletions(-)
|
||||
|
||||
diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c
|
||||
index 84bc022f9e5b..e3de49e671dc 100644
|
||||
--- a/drivers/soc/rockchip/pm_domains.c
|
||||
+++ b/drivers/soc/rockchip/pm_domains.c
|
||||
@@ -43,8 +43,10 @@ struct rockchip_domain_info {
|
||||
bool active_wakeup;
|
||||
int pwr_w_mask;
|
||||
int req_w_mask;
|
||||
+ int mem_status_mask;
|
||||
int repair_status_mask;
|
||||
u32 pwr_offset;
|
||||
+ u32 mem_offset;
|
||||
u32 req_offset;
|
||||
};
|
||||
|
||||
@@ -54,6 +56,9 @@ struct rockchip_pmu_info {
|
||||
u32 req_offset;
|
||||
u32 idle_offset;
|
||||
u32 ack_offset;
|
||||
+ u32 mem_pwr_offset;
|
||||
+ u32 chain_status_offset;
|
||||
+ u32 mem_status_offset;
|
||||
u32 repair_status_offset;
|
||||
|
||||
u32 core_pwrcnt_offset;
|
||||
@@ -119,13 +124,15 @@ struct rockchip_pmu {
|
||||
.active_wakeup = wakeup, \
|
||||
}
|
||||
|
||||
-#define DOMAIN_M_O_R(_name, p_offset, pwr, status, r_status, r_offset, req, idle, ack, wakeup) \
|
||||
+#define DOMAIN_M_O_R(_name, p_offset, pwr, status, m_offset, m_status, r_status, r_offset, req, idle, ack, wakeup) \
|
||||
{ \
|
||||
.name = _name, \
|
||||
.pwr_offset = p_offset, \
|
||||
.pwr_w_mask = (pwr) << 16, \
|
||||
.pwr_mask = (pwr), \
|
||||
.status_mask = (status), \
|
||||
+ .mem_offset = m_offset, \
|
||||
+ .mem_status_mask = (m_status), \
|
||||
.repair_status_mask = (r_status), \
|
||||
.req_offset = r_offset, \
|
||||
.req_w_mask = (req) << 16, \
|
||||
@@ -269,8 +276,8 @@ void rockchip_pmu_unblock(void)
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(rockchip_pmu_unblock);
|
||||
|
||||
-#define DOMAIN_RK3588(name, p_offset, pwr, status, r_status, r_offset, req, idle, wakeup) \
|
||||
- DOMAIN_M_O_R(name, p_offset, pwr, status, r_status, r_offset, req, idle, idle, wakeup)
|
||||
+#define DOMAIN_RK3588(name, p_offset, pwr, status, m_offset, m_status, r_status, r_offset, req, idle, wakeup) \
|
||||
+ DOMAIN_M_O_R(name, p_offset, pwr, status, m_offset, m_status, r_status, r_offset, req, idle, idle, wakeup)
|
||||
|
||||
static bool rockchip_pmu_domain_is_idle(struct rockchip_pm_domain *pd)
|
||||
{
|
||||
@@ -408,17 +415,92 @@ static bool rockchip_pmu_domain_is_on(struct rockchip_pm_domain *pd)
|
||||
return !(val & pd->info->status_mask);
|
||||
}
|
||||
|
||||
+static bool rockchip_pmu_domain_is_mem_on(struct rockchip_pm_domain *pd)
|
||||
+{
|
||||
+ struct rockchip_pmu *pmu = pd->pmu;
|
||||
+ unsigned int val;
|
||||
+
|
||||
+ regmap_read(pmu->regmap,
|
||||
+ pmu->info->mem_status_offset + pd->info->mem_offset, &val);
|
||||
+
|
||||
+ /* 1'b0: power on, 1'b1: power off */
|
||||
+ return !(val & pd->info->mem_status_mask);
|
||||
+}
|
||||
+
|
||||
+static bool rockchip_pmu_domain_is_chain_on(struct rockchip_pm_domain *pd)
|
||||
+{
|
||||
+ struct rockchip_pmu *pmu = pd->pmu;
|
||||
+ unsigned int val;
|
||||
+
|
||||
+ regmap_read(pmu->regmap,
|
||||
+ pmu->info->chain_status_offset + pd->info->mem_offset, &val);
|
||||
+
|
||||
+ /* 1'b1: power on, 1'b0: power off */
|
||||
+ return val & pd->info->mem_status_mask;
|
||||
+}
|
||||
+
|
||||
+static int rockchip_pmu_domain_mem_reset(struct rockchip_pm_domain *pd)
|
||||
+{
|
||||
+ struct rockchip_pmu *pmu = pd->pmu;
|
||||
+ struct generic_pm_domain *genpd = &pd->genpd;
|
||||
+ bool is_on;
|
||||
+ int ret = 0;
|
||||
+
|
||||
+ ret = readx_poll_timeout_atomic(rockchip_pmu_domain_is_chain_on, pd, is_on,
|
||||
+ is_on == true, 0, 10000);
|
||||
+ if (ret) {
|
||||
+ dev_err(pmu->dev,
|
||||
+ "failed to get chain status '%s', target_on=1, val=%d\n",
|
||||
+ genpd->name, is_on);
|
||||
+ goto error;
|
||||
+ }
|
||||
+
|
||||
+ udelay(20);
|
||||
+
|
||||
+ regmap_write(pmu->regmap, pmu->info->mem_pwr_offset + pd->info->pwr_offset,
|
||||
+ (pd->info->pwr_mask | pd->info->pwr_w_mask));
|
||||
+ wmb();
|
||||
+
|
||||
+ ret = readx_poll_timeout_atomic(rockchip_pmu_domain_is_mem_on, pd, is_on,
|
||||
+ is_on == false, 0, 10000);
|
||||
+ if (ret) {
|
||||
+ dev_err(pmu->dev,
|
||||
+ "failed to get mem status '%s', target_on=0, val=%d\n",
|
||||
+ genpd->name, is_on);
|
||||
+ goto error;
|
||||
+ }
|
||||
+
|
||||
+ regmap_write(pmu->regmap, pmu->info->mem_pwr_offset + pd->info->pwr_offset,
|
||||
+ pd->info->pwr_w_mask);
|
||||
+ wmb();
|
||||
+
|
||||
+ ret = readx_poll_timeout_atomic(rockchip_pmu_domain_is_mem_on, pd, is_on,
|
||||
+ is_on == true, 0, 10000);
|
||||
+ if (ret) {
|
||||
+ dev_err(pmu->dev,
|
||||
+ "failed to get mem status '%s', target_on=1, val=%d\n",
|
||||
+ genpd->name, is_on);
|
||||
+ }
|
||||
+
|
||||
+error:
|
||||
+ return ret;
|
||||
+}
|
||||
+
|
||||
static void rockchip_do_pmu_set_power_domain(struct rockchip_pm_domain *pd,
|
||||
bool on)
|
||||
{
|
||||
struct rockchip_pmu *pmu = pd->pmu;
|
||||
struct generic_pm_domain *genpd = &pd->genpd;
|
||||
u32 pd_pwr_offset = pd->info->pwr_offset;
|
||||
- bool is_on;
|
||||
+ bool is_on, is_mem_on = false;
|
||||
|
||||
if (pd->info->pwr_mask == 0)
|
||||
return;
|
||||
- else if (pd->info->pwr_w_mask)
|
||||
+
|
||||
+ if (on && pd->info->mem_status_mask)
|
||||
+ is_mem_on = rockchip_pmu_domain_is_mem_on(pd);
|
||||
+
|
||||
+ if (pd->info->pwr_w_mask)
|
||||
regmap_write(pmu->regmap, pmu->info->pwr_offset + pd_pwr_offset,
|
||||
on ? pd->info->pwr_w_mask :
|
||||
(pd->info->pwr_mask | pd->info->pwr_w_mask));
|
||||
@@ -428,6 +510,9 @@ static void rockchip_do_pmu_set_power_domain(struct rockchip_pm_domain *pd,
|
||||
|
||||
wmb();
|
||||
|
||||
+ if (is_mem_on && rockchip_pmu_domain_mem_reset(pd))
|
||||
+ return;
|
||||
+
|
||||
if (readx_poll_timeout_atomic(rockchip_pmu_domain_is_on, pd, is_on,
|
||||
is_on == on, 0, 10000)) {
|
||||
dev_err(pmu->dev,
|
||||
@@ -645,7 +730,9 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu,
|
||||
pd->genpd.flags = GENPD_FLAG_PM_CLK;
|
||||
if (pd_info->active_wakeup)
|
||||
pd->genpd.flags |= GENPD_FLAG_ACTIVE_WAKEUP;
|
||||
- pm_genpd_init(&pd->genpd, NULL, !rockchip_pmu_domain_is_on(pd));
|
||||
+ pm_genpd_init(&pd->genpd, NULL,
|
||||
+ !rockchip_pmu_domain_is_on(pd) ||
|
||||
+ (pd->info->mem_status_mask && !rockchip_pmu_domain_is_mem_on(pd)));
|
||||
|
||||
pmu->genpd_data.domains[id] = &pd->genpd;
|
||||
return 0;
|
||||
@@ -1024,35 +1111,35 @@ static const struct rockchip_domain_info rk3568_pm_domains[] = {
|
||||
};
|
||||
|
||||
static const struct rockchip_domain_info rk3588_pm_domains[] = {
|
||||
- [RK3588_PD_GPU] = DOMAIN_RK3588("gpu", 0x0, BIT(0), 0, BIT(1), 0x0, BIT(0), BIT(0), false),
|
||||
- [RK3588_PD_NPU] = DOMAIN_RK3588("npu", 0x0, BIT(1), BIT(1), 0, 0x0, 0, 0, false),
|
||||
- [RK3588_PD_VCODEC] = DOMAIN_RK3588("vcodec", 0x0, BIT(2), BIT(2), 0, 0x0, 0, 0, false),
|
||||
- [RK3588_PD_NPUTOP] = DOMAIN_RK3588("nputop", 0x0, BIT(3), 0, BIT(2), 0x0, BIT(1), BIT(1), false),
|
||||
- [RK3588_PD_NPU1] = DOMAIN_RK3588("npu1", 0x0, BIT(4), 0, BIT(3), 0x0, BIT(2), BIT(2), false),
|
||||
- [RK3588_PD_NPU2] = DOMAIN_RK3588("npu2", 0x0, BIT(5), 0, BIT(4), 0x0, BIT(3), BIT(3), false),
|
||||
- [RK3588_PD_VENC0] = DOMAIN_RK3588("venc0", 0x0, BIT(6), 0, BIT(5), 0x0, BIT(4), BIT(4), false),
|
||||
- [RK3588_PD_VENC1] = DOMAIN_RK3588("venc1", 0x0, BIT(7), 0, BIT(6), 0x0, BIT(5), BIT(5), false),
|
||||
- [RK3588_PD_RKVDEC0] = DOMAIN_RK3588("rkvdec0", 0x0, BIT(8), 0, BIT(7), 0x0, BIT(6), BIT(6), false),
|
||||
- [RK3588_PD_RKVDEC1] = DOMAIN_RK3588("rkvdec1", 0x0, BIT(9), 0, BIT(8), 0x0, BIT(7), BIT(7), false),
|
||||
- [RK3588_PD_VDPU] = DOMAIN_RK3588("vdpu", 0x0, BIT(10), 0, BIT(9), 0x0, BIT(8), BIT(8), false),
|
||||
- [RK3588_PD_RGA30] = DOMAIN_RK3588("rga30", 0x0, BIT(11), 0, BIT(10), 0x0, 0, 0, false),
|
||||
- [RK3588_PD_AV1] = DOMAIN_RK3588("av1", 0x0, BIT(12), 0, BIT(11), 0x0, BIT(9), BIT(9), false),
|
||||
- [RK3588_PD_VI] = DOMAIN_RK3588("vi", 0x0, BIT(13), 0, BIT(12), 0x0, BIT(10), BIT(10), false),
|
||||
- [RK3588_PD_FEC] = DOMAIN_RK3588("fec", 0x0, BIT(14), 0, BIT(13), 0x0, 0, 0, false),
|
||||
- [RK3588_PD_ISP1] = DOMAIN_RK3588("isp1", 0x0, BIT(15), 0, BIT(14), 0x0, BIT(11), BIT(11), false),
|
||||
- [RK3588_PD_RGA31] = DOMAIN_RK3588("rga31", 0x4, BIT(0), 0, BIT(15), 0x0, BIT(12), BIT(12), false),
|
||||
- [RK3588_PD_VOP] = DOMAIN_RK3588("vop", 0x4, BIT(1), 0, BIT(16), 0x0, BIT(13) | BIT(14), BIT(13) | BIT(14), false),
|
||||
- [RK3588_PD_VO0] = DOMAIN_RK3588("vo0", 0x4, BIT(2), 0, BIT(17), 0x0, BIT(15), BIT(15), false),
|
||||
- [RK3588_PD_VO1] = DOMAIN_RK3588("vo1", 0x4, BIT(3), 0, BIT(18), 0x4, BIT(0), BIT(16), false),
|
||||
- [RK3588_PD_AUDIO] = DOMAIN_RK3588("audio", 0x4, BIT(4), 0, BIT(19), 0x4, BIT(1), BIT(17), false),
|
||||
- [RK3588_PD_PHP] = DOMAIN_RK3588("php", 0x4, BIT(5), 0, BIT(20), 0x4, BIT(5), BIT(21), false),
|
||||
- [RK3588_PD_GMAC] = DOMAIN_RK3588("gmac", 0x4, BIT(6), 0, BIT(21), 0x0, 0, 0, false),
|
||||
- [RK3588_PD_PCIE] = DOMAIN_RK3588("pcie", 0x4, BIT(7), 0, BIT(22), 0x0, 0, 0, true),
|
||||
- [RK3588_PD_NVM] = DOMAIN_RK3588("nvm", 0x4, BIT(8), BIT(24), 0, 0x4, BIT(2), BIT(18), false),
|
||||
- [RK3588_PD_NVM0] = DOMAIN_RK3588("nvm0", 0x4, BIT(9), 0, BIT(23), 0x0, 0, 0, false),
|
||||
- [RK3588_PD_SDIO] = DOMAIN_RK3588("sdio", 0x4, BIT(10), 0, BIT(24), 0x4, BIT(3), BIT(19), false),
|
||||
- [RK3588_PD_USB] = DOMAIN_RK3588("usb", 0x4, BIT(11), 0, BIT(25), 0x4, BIT(4), BIT(20), true),
|
||||
- [RK3588_PD_SDMMC] = DOMAIN_RK3588("sdmmc", 0x4, BIT(13), 0, BIT(26), 0x0, 0, 0, false),
|
||||
+ [RK3588_PD_GPU] = DOMAIN_RK3588("gpu", 0x0, BIT(0), 0, 0x0, 0, BIT(1), 0x0, BIT(0), BIT(0), false),
|
||||
+ [RK3588_PD_NPU] = DOMAIN_RK3588("npu", 0x0, BIT(1), BIT(1), 0x0, 0, 0, 0x0, 0, 0, false),
|
||||
+ [RK3588_PD_VCODEC] = DOMAIN_RK3588("vcodec", 0x0, BIT(2), BIT(2), 0x0, 0, 0, 0x0, 0, 0, false),
|
||||
+ [RK3588_PD_NPUTOP] = DOMAIN_RK3588("nputop", 0x0, BIT(3), 0, 0x0, BIT(11), BIT(2), 0x0, BIT(1), BIT(1), false),
|
||||
+ [RK3588_PD_NPU1] = DOMAIN_RK3588("npu1", 0x0, BIT(4), 0, 0x0, BIT(12), BIT(3), 0x0, BIT(2), BIT(2), false),
|
||||
+ [RK3588_PD_NPU2] = DOMAIN_RK3588("npu2", 0x0, BIT(5), 0, 0x0, BIT(13), BIT(4), 0x0, BIT(3), BIT(3), false),
|
||||
+ [RK3588_PD_VENC0] = DOMAIN_RK3588("venc0", 0x0, BIT(6), 0, 0x0, BIT(14), BIT(5), 0x0, BIT(4), BIT(4), false),
|
||||
+ [RK3588_PD_VENC1] = DOMAIN_RK3588("venc1", 0x0, BIT(7), 0, 0x0, BIT(15), BIT(6), 0x0, BIT(5), BIT(5), false),
|
||||
+ [RK3588_PD_RKVDEC0] = DOMAIN_RK3588("rkvdec0", 0x0, BIT(8), 0, 0x0, BIT(16), BIT(7), 0x0, BIT(6), BIT(6), false),
|
||||
+ [RK3588_PD_RKVDEC1] = DOMAIN_RK3588("rkvdec1", 0x0, BIT(9), 0, 0x0, BIT(17), BIT(8), 0x0, BIT(7), BIT(7), false),
|
||||
+ [RK3588_PD_VDPU] = DOMAIN_RK3588("vdpu", 0x0, BIT(10), 0, 0x0, BIT(18), BIT(9), 0x0, BIT(8), BIT(8), false),
|
||||
+ [RK3588_PD_RGA30] = DOMAIN_RK3588("rga30", 0x0, BIT(11), 0, 0x0, BIT(19), BIT(10), 0x0, 0, 0, false),
|
||||
+ [RK3588_PD_AV1] = DOMAIN_RK3588("av1", 0x0, BIT(12), 0, 0x0, BIT(20), BIT(11), 0x0, BIT(9), BIT(9), false),
|
||||
+ [RK3588_PD_VI] = DOMAIN_RK3588("vi", 0x0, BIT(13), 0, 0x0, BIT(21), BIT(12), 0x0, BIT(10), BIT(10), false),
|
||||
+ [RK3588_PD_FEC] = DOMAIN_RK3588("fec", 0x0, BIT(14), 0, 0x0, BIT(22), BIT(13), 0x0, 0, 0, false),
|
||||
+ [RK3588_PD_ISP1] = DOMAIN_RK3588("isp1", 0x0, BIT(15), 0, 0x0, BIT(23), BIT(14), 0x0, BIT(11), BIT(11), false),
|
||||
+ [RK3588_PD_RGA31] = DOMAIN_RK3588("rga31", 0x4, BIT(0), 0, 0x0, BIT(24), BIT(15), 0x0, BIT(12), BIT(12), false),
|
||||
+ [RK3588_PD_VOP] = DOMAIN_RK3588("vop", 0x4, BIT(1), 0, 0x0, BIT(25), BIT(16), 0x0, BIT(13) | BIT(14), BIT(13) | BIT(14), false),
|
||||
+ [RK3588_PD_VO0] = DOMAIN_RK3588("vo0", 0x4, BIT(2), 0, 0x0, BIT(26), BIT(17), 0x0, BIT(15), BIT(15), false),
|
||||
+ [RK3588_PD_VO1] = DOMAIN_RK3588("vo1", 0x4, BIT(3), 0, 0x0, BIT(27), BIT(18), 0x4, BIT(0), BIT(16), false),
|
||||
+ [RK3588_PD_AUDIO] = DOMAIN_RK3588("audio", 0x4, BIT(4), 0, 0x0, BIT(28), BIT(19), 0x4, BIT(1), BIT(17), false),
|
||||
+ [RK3588_PD_PHP] = DOMAIN_RK3588("php", 0x4, BIT(5), 0, 0x0, BIT(29), BIT(20), 0x4, BIT(5), BIT(21), false),
|
||||
+ [RK3588_PD_GMAC] = DOMAIN_RK3588("gmac", 0x4, BIT(6), 0, 0x0, BIT(30), BIT(21), 0x0, 0, 0, false),
|
||||
+ [RK3588_PD_PCIE] = DOMAIN_RK3588("pcie", 0x4, BIT(7), 0, 0x0, BIT(31), BIT(22), 0x0, 0, 0, true),
|
||||
+ [RK3588_PD_NVM] = DOMAIN_RK3588("nvm", 0x4, BIT(8), BIT(24), 0x4, 0, 0, 0x4, BIT(2), BIT(18), false),
|
||||
+ [RK3588_PD_NVM0] = DOMAIN_RK3588("nvm0", 0x4, BIT(9), 0, 0x4, BIT(1), BIT(23), 0x0, 0, 0, false),
|
||||
+ [RK3588_PD_SDIO] = DOMAIN_RK3588("sdio", 0x4, BIT(10), 0, 0x4, BIT(2), BIT(24), 0x4, BIT(3), BIT(19), false),
|
||||
+ [RK3588_PD_USB] = DOMAIN_RK3588("usb", 0x4, BIT(11), 0, 0x4, BIT(3), BIT(25), 0x4, BIT(4), BIT(20), true),
|
||||
+ [RK3588_PD_SDMMC] = DOMAIN_RK3588("sdmmc", 0x4, BIT(13), 0, 0x4, BIT(5), BIT(26), 0x0, 0, 0, false),
|
||||
};
|
||||
|
||||
static const struct rockchip_pmu_info px30_pmu = {
|
||||
@@ -1207,6 +1294,9 @@ static const struct rockchip_pmu_info rk3588_pmu = {
|
||||
.req_offset = 0x10c,
|
||||
.idle_offset = 0x120,
|
||||
.ack_offset = 0x118,
|
||||
+ .mem_pwr_offset = 0x1a0,
|
||||
+ .chain_status_offset = 0x1f0,
|
||||
+ .mem_status_offset = 0x1f8,
|
||||
.repair_status_offset = 0x290,
|
||||
|
||||
.num_domains = ARRAY_SIZE(rk3588_pm_domains),
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,34 @@
|
||||
From 63cae5a6a417199ccc1965ceb1e1915a0b3c3e10 Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Wed, 19 Apr 2023 21:13:09 +0300
|
||||
Subject: [PATCH 1/1] arm64: dts: rockchip: Add rk3588 timer
|
||||
|
||||
Add DT node for Rockchip RK3588/RK3588S SoC timer.
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 8 ++++++++
|
||||
1 file changed, 8 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index 05af9a0fddf4..96fb3a6e0c68 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -1805,6 +1805,14 @@ i2c5: i2c@fead0000 {
|
||||
status = "disabled";
|
||||
};
|
||||
|
||||
+ timer0: timer@feae0000 {
|
||||
+ compatible = "rockchip,rk3588-timer", "rockchip,rk3288-timer";
|
||||
+ reg = <0x0 0xfeae0000 0x0 0x20>;
|
||||
+ interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ clocks = <&cru PCLK_BUSTIMER0>, <&cru CLK_BUSTIMER0>;
|
||||
+ clock-names = "pclk", "timer";
|
||||
+ };
|
||||
+
|
||||
wdt: watchdog@feaf0000 {
|
||||
compatible = "rockchip,rk3588-wdt", "snps,dw-wdt";
|
||||
reg = <0x0 0xfeaf0000 0x0 0x100>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
684
patch/kernel/rockchip-rk3588-edge/0020-RK3588-ADC-support.patch
Normal file
684
patch/kernel/rockchip-rk3588-edge/0020-RK3588-ADC-support.patch
Normal file
@@ -0,0 +1,684 @@
|
||||
From cd425173fe5788b5bc17cc4a3de7c68fd571d151 Mon Sep 17 00:00:00 2001
|
||||
From: Simon Xue <xxm@rock-chips.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:33 +0530
|
||||
Subject: [PATCH 1/9] iio: adc: rockchip_saradc: Add callback functions
|
||||
|
||||
Add start, read and power_down callback functions,
|
||||
which will help in adding new rockchip device support
|
||||
cleanly.
|
||||
|
||||
Signed-off-by: Simon Xue <xxm@rock-chips.com>
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
---
|
||||
drivers/iio/adc/rockchip_saradc.c | 64 +++++++++++++++++++++++++------
|
||||
1 file changed, 52 insertions(+), 12 deletions(-)
|
||||
|
||||
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
|
||||
index 79448c5ffc2a..21f9d92a6af4 100644
|
||||
--- a/drivers/iio/adc/rockchip_saradc.c
|
||||
+++ b/drivers/iio/adc/rockchip_saradc.c
|
||||
@@ -38,10 +38,15 @@
|
||||
#define SARADC_TIMEOUT msecs_to_jiffies(100)
|
||||
#define SARADC_MAX_CHANNELS 8
|
||||
|
||||
+struct rockchip_saradc;
|
||||
+
|
||||
struct rockchip_saradc_data {
|
||||
const struct iio_chan_spec *channels;
|
||||
int num_channels;
|
||||
unsigned long clk_rate;
|
||||
+ void (*start)(struct rockchip_saradc *info, int chn);
|
||||
+ int (*read)(struct rockchip_saradc *info);
|
||||
+ void (*power_down)(struct rockchip_saradc *info);
|
||||
};
|
||||
|
||||
struct rockchip_saradc {
|
||||
@@ -60,27 +65,50 @@ struct rockchip_saradc {
|
||||
struct notifier_block nb;
|
||||
};
|
||||
|
||||
-static void rockchip_saradc_power_down(struct rockchip_saradc *info)
|
||||
+static void rockchip_saradc_reset_controller(struct reset_control *reset);
|
||||
+
|
||||
+static void rockchip_saradc_start_v1(struct rockchip_saradc *info, int chn)
|
||||
+{
|
||||
+ /* 8 clock periods as delay between power up and start cmd */
|
||||
+ writel_relaxed(8, info->regs + SARADC_DLY_PU_SOC);
|
||||
+ /* Select the channel to be used and trigger conversion */
|
||||
+ writel(SARADC_CTRL_POWER_CTRL | (chn & SARADC_CTRL_CHN_MASK) |
|
||||
+ SARADC_CTRL_IRQ_ENABLE, info->regs + SARADC_CTRL);
|
||||
+}
|
||||
+
|
||||
+static void rockchip_saradc_start(struct rockchip_saradc *info, int chn)
|
||||
+{
|
||||
+ info->data->start(info, chn);
|
||||
+}
|
||||
+
|
||||
+static int rockchip_saradc_read_v1(struct rockchip_saradc *info)
|
||||
+{
|
||||
+ return readl_relaxed(info->regs + SARADC_DATA);
|
||||
+}
|
||||
+
|
||||
+static int rockchip_saradc_read(struct rockchip_saradc *info)
|
||||
+{
|
||||
+ return info->data->read(info);
|
||||
+}
|
||||
+
|
||||
+static void rockchip_saradc_power_down_v1(struct rockchip_saradc *info)
|
||||
{
|
||||
- /* Clear irq & power down adc */
|
||||
writel_relaxed(0, info->regs + SARADC_CTRL);
|
||||
}
|
||||
|
||||
+static void rockchip_saradc_power_down(struct rockchip_saradc *info)
|
||||
+{
|
||||
+ if (info->data->power_down)
|
||||
+ info->data->power_down(info);
|
||||
+}
|
||||
+
|
||||
static int rockchip_saradc_conversion(struct rockchip_saradc *info,
|
||||
struct iio_chan_spec const *chan)
|
||||
{
|
||||
reinit_completion(&info->completion);
|
||||
|
||||
- /* 8 clock periods as delay between power up and start cmd */
|
||||
- writel_relaxed(8, info->regs + SARADC_DLY_PU_SOC);
|
||||
-
|
||||
info->last_chan = chan;
|
||||
-
|
||||
- /* Select the channel to be used and trigger conversion */
|
||||
- writel(SARADC_CTRL_POWER_CTRL
|
||||
- | (chan->channel & SARADC_CTRL_CHN_MASK)
|
||||
- | SARADC_CTRL_IRQ_ENABLE,
|
||||
- info->regs + SARADC_CTRL);
|
||||
+ rockchip_saradc_start(info, chan->channel);
|
||||
|
||||
if (!wait_for_completion_timeout(&info->completion, SARADC_TIMEOUT))
|
||||
return -ETIMEDOUT;
|
||||
@@ -123,7 +151,7 @@ static irqreturn_t rockchip_saradc_isr(int irq, void *dev_id)
|
||||
struct rockchip_saradc *info = dev_id;
|
||||
|
||||
/* Read value */
|
||||
- info->last_val = readl_relaxed(info->regs + SARADC_DATA);
|
||||
+ info->last_val = rockchip_saradc_read(info);
|
||||
info->last_val &= GENMASK(info->last_chan->scan_type.realbits - 1, 0);
|
||||
|
||||
rockchip_saradc_power_down(info);
|
||||
@@ -163,6 +191,9 @@ static const struct rockchip_saradc_data saradc_data = {
|
||||
.channels = rockchip_saradc_iio_channels,
|
||||
.num_channels = ARRAY_SIZE(rockchip_saradc_iio_channels),
|
||||
.clk_rate = 1000000,
|
||||
+ .start = rockchip_saradc_start_v1,
|
||||
+ .read = rockchip_saradc_read_v1,
|
||||
+ .power_down = rockchip_saradc_power_down_v1,
|
||||
};
|
||||
|
||||
static const struct iio_chan_spec rockchip_rk3066_tsadc_iio_channels[] = {
|
||||
@@ -174,6 +205,9 @@ static const struct rockchip_saradc_data rk3066_tsadc_data = {
|
||||
.channels = rockchip_rk3066_tsadc_iio_channels,
|
||||
.num_channels = ARRAY_SIZE(rockchip_rk3066_tsadc_iio_channels),
|
||||
.clk_rate = 50000,
|
||||
+ .start = rockchip_saradc_start_v1,
|
||||
+ .read = rockchip_saradc_read_v1,
|
||||
+ .power_down = rockchip_saradc_power_down_v1,
|
||||
};
|
||||
|
||||
static const struct iio_chan_spec rockchip_rk3399_saradc_iio_channels[] = {
|
||||
@@ -189,6 +223,9 @@ static const struct rockchip_saradc_data rk3399_saradc_data = {
|
||||
.channels = rockchip_rk3399_saradc_iio_channels,
|
||||
.num_channels = ARRAY_SIZE(rockchip_rk3399_saradc_iio_channels),
|
||||
.clk_rate = 1000000,
|
||||
+ .start = rockchip_saradc_start_v1,
|
||||
+ .read = rockchip_saradc_read_v1,
|
||||
+ .power_down = rockchip_saradc_power_down_v1,
|
||||
};
|
||||
|
||||
static const struct iio_chan_spec rockchip_rk3568_saradc_iio_channels[] = {
|
||||
@@ -206,6 +243,9 @@ static const struct rockchip_saradc_data rk3568_saradc_data = {
|
||||
.channels = rockchip_rk3568_saradc_iio_channels,
|
||||
.num_channels = ARRAY_SIZE(rockchip_rk3568_saradc_iio_channels),
|
||||
.clk_rate = 1000000,
|
||||
+ .start = rockchip_saradc_start_v1,
|
||||
+ .read = rockchip_saradc_read_v1,
|
||||
+ .power_down = rockchip_saradc_power_down_v1,
|
||||
};
|
||||
|
||||
static const struct of_device_id rockchip_saradc_match[] = {
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From b5d9db8b105387c66c2c44096a622c6d9adfd5e6 Mon Sep 17 00:00:00 2001
|
||||
From: Simon Xue <xxm@rock-chips.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:34 +0530
|
||||
Subject: [PATCH 2/9] iio: adc: rockchip_saradc: Add support for RK3588
|
||||
|
||||
Add new start and read functions to support rk3588 device.
|
||||
Also, add a device compatible string for the same.
|
||||
|
||||
Signed-off-by: Simon Xue <xxm@rock-chips.com>
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
|
||||
---
|
||||
drivers/iio/adc/rockchip_saradc.c | 70 +++++++++++++++++++++++++++++++
|
||||
1 file changed, 70 insertions(+)
|
||||
|
||||
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
|
||||
index 21f9d92a6af4..312286ec91dc 100644
|
||||
--- a/drivers/iio/adc/rockchip_saradc.c
|
||||
+++ b/drivers/iio/adc/rockchip_saradc.c
|
||||
@@ -4,6 +4,7 @@
|
||||
* Copyright (C) 2014 ROCKCHIP, Inc.
|
||||
*/
|
||||
|
||||
+#include <linux/bitfield.h>
|
||||
#include <linux/module.h>
|
||||
#include <linux/mutex.h>
|
||||
#include <linux/platform_device.h>
|
||||
@@ -38,6 +39,22 @@
|
||||
#define SARADC_TIMEOUT msecs_to_jiffies(100)
|
||||
#define SARADC_MAX_CHANNELS 8
|
||||
|
||||
+/* v2 registers */
|
||||
+#define SARADC2_CONV_CON 0x0
|
||||
+#define SARADC_T_PD_SOC 0x4
|
||||
+#define SARADC_T_DAS_SOC 0xc
|
||||
+#define SARADC2_END_INT_EN 0x104
|
||||
+#define SARADC2_ST_CON 0x108
|
||||
+#define SARADC2_STATUS 0x10c
|
||||
+#define SARADC2_END_INT_ST 0x110
|
||||
+#define SARADC2_DATA_BASE 0x120
|
||||
+
|
||||
+#define SARADC2_EN_END_INT BIT(0)
|
||||
+#define SARADC2_START BIT(4)
|
||||
+#define SARADC2_SINGLE_MODE BIT(5)
|
||||
+
|
||||
+#define SARADC2_CONV_CHANNELS GENMASK(15, 0)
|
||||
+
|
||||
struct rockchip_saradc;
|
||||
|
||||
struct rockchip_saradc_data {
|
||||
@@ -76,6 +93,25 @@ static void rockchip_saradc_start_v1(struct rockchip_saradc *info, int chn)
|
||||
SARADC_CTRL_IRQ_ENABLE, info->regs + SARADC_CTRL);
|
||||
}
|
||||
|
||||
+static void rockchip_saradc_start_v2(struct rockchip_saradc *info, int chn)
|
||||
+{
|
||||
+ int val;
|
||||
+
|
||||
+ if (info->reset)
|
||||
+ rockchip_saradc_reset_controller(info->reset);
|
||||
+
|
||||
+ writel_relaxed(0xc, info->regs + SARADC_T_DAS_SOC);
|
||||
+ writel_relaxed(0x20, info->regs + SARADC_T_PD_SOC);
|
||||
+ val = FIELD_PREP(SARADC2_EN_END_INT, 1);
|
||||
+ val |= val << 16;
|
||||
+ writel_relaxed(val, info->regs + SARADC2_END_INT_EN);
|
||||
+ val = FIELD_PREP(SARADC2_START, 1) |
|
||||
+ FIELD_PREP(SARADC2_SINGLE_MODE, 1) |
|
||||
+ FIELD_PREP(SARADC2_CONV_CHANNELS, chn);
|
||||
+ val |= val << 16;
|
||||
+ writel(val, info->regs + SARADC2_CONV_CON);
|
||||
+}
|
||||
+
|
||||
static void rockchip_saradc_start(struct rockchip_saradc *info, int chn)
|
||||
{
|
||||
info->data->start(info, chn);
|
||||
@@ -86,6 +122,18 @@ static int rockchip_saradc_read_v1(struct rockchip_saradc *info)
|
||||
return readl_relaxed(info->regs + SARADC_DATA);
|
||||
}
|
||||
|
||||
+static int rockchip_saradc_read_v2(struct rockchip_saradc *info)
|
||||
+{
|
||||
+ int offset;
|
||||
+
|
||||
+ /* Clear irq */
|
||||
+ writel_relaxed(0x1, info->regs + SARADC2_END_INT_ST);
|
||||
+
|
||||
+ offset = SARADC2_DATA_BASE + info->last_chan->channel * 0x4;
|
||||
+
|
||||
+ return readl_relaxed(info->regs + offset);
|
||||
+}
|
||||
+
|
||||
static int rockchip_saradc_read(struct rockchip_saradc *info)
|
||||
{
|
||||
return info->data->read(info);
|
||||
@@ -248,6 +296,25 @@ static const struct rockchip_saradc_data rk3568_saradc_data = {
|
||||
.power_down = rockchip_saradc_power_down_v1,
|
||||
};
|
||||
|
||||
+static const struct iio_chan_spec rockchip_rk3588_saradc_iio_channels[] = {
|
||||
+ SARADC_CHANNEL(0, "adc0", 12),
|
||||
+ SARADC_CHANNEL(1, "adc1", 12),
|
||||
+ SARADC_CHANNEL(2, "adc2", 12),
|
||||
+ SARADC_CHANNEL(3, "adc3", 12),
|
||||
+ SARADC_CHANNEL(4, "adc4", 12),
|
||||
+ SARADC_CHANNEL(5, "adc5", 12),
|
||||
+ SARADC_CHANNEL(6, "adc6", 12),
|
||||
+ SARADC_CHANNEL(7, "adc7", 12),
|
||||
+};
|
||||
+
|
||||
+static const struct rockchip_saradc_data rk3588_saradc_data = {
|
||||
+ .channels = rockchip_rk3588_saradc_iio_channels,
|
||||
+ .num_channels = ARRAY_SIZE(rockchip_rk3588_saradc_iio_channels),
|
||||
+ .clk_rate = 1000000,
|
||||
+ .start = rockchip_saradc_start_v2,
|
||||
+ .read = rockchip_saradc_read_v2,
|
||||
+};
|
||||
+
|
||||
static const struct of_device_id rockchip_saradc_match[] = {
|
||||
{
|
||||
.compatible = "rockchip,saradc",
|
||||
@@ -261,6 +328,9 @@ static const struct of_device_id rockchip_saradc_match[] = {
|
||||
}, {
|
||||
.compatible = "rockchip,rk3568-saradc",
|
||||
.data = &rk3568_saradc_data,
|
||||
+ }, {
|
||||
+ .compatible = "rockchip,rk3588-saradc",
|
||||
+ .data = &rk3588_saradc_data,
|
||||
},
|
||||
{},
|
||||
};
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From a0ba1f7d0b8ce5cfeff1253d99556704a4b70139 Mon Sep 17 00:00:00 2001
|
||||
From: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:35 +0530
|
||||
Subject: [PATCH 3/9] iio: adc: rockchip_saradc: Make use of
|
||||
devm_clk_get_enabled
|
||||
|
||||
Use devm_clk_get_enabled() to avoid manually disabling the
|
||||
clock.
|
||||
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
---
|
||||
drivers/iio/adc/rockchip_saradc.c | 56 +++++--------------------------
|
||||
1 file changed, 8 insertions(+), 48 deletions(-)
|
||||
|
||||
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
|
||||
index 312286ec91dc..ac424ea50787 100644
|
||||
--- a/drivers/iio/adc/rockchip_saradc.c
|
||||
+++ b/drivers/iio/adc/rockchip_saradc.c
|
||||
@@ -346,20 +346,6 @@ static void rockchip_saradc_reset_controller(struct reset_control *reset)
|
||||
reset_control_deassert(reset);
|
||||
}
|
||||
|
||||
-static void rockchip_saradc_clk_disable(void *data)
|
||||
-{
|
||||
- struct rockchip_saradc *info = data;
|
||||
-
|
||||
- clk_disable_unprepare(info->clk);
|
||||
-}
|
||||
-
|
||||
-static void rockchip_saradc_pclk_disable(void *data)
|
||||
-{
|
||||
- struct rockchip_saradc *info = data;
|
||||
-
|
||||
- clk_disable_unprepare(info->pclk);
|
||||
-}
|
||||
-
|
||||
static void rockchip_saradc_regulator_disable(void *data)
|
||||
{
|
||||
struct rockchip_saradc *info = data;
|
||||
@@ -493,16 +479,6 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
|
||||
return ret;
|
||||
}
|
||||
|
||||
- info->pclk = devm_clk_get(&pdev->dev, "apb_pclk");
|
||||
- if (IS_ERR(info->pclk))
|
||||
- return dev_err_probe(&pdev->dev, PTR_ERR(info->pclk),
|
||||
- "failed to get pclk\n");
|
||||
-
|
||||
- info->clk = devm_clk_get(&pdev->dev, "saradc");
|
||||
- if (IS_ERR(info->clk))
|
||||
- return dev_err_probe(&pdev->dev, PTR_ERR(info->clk),
|
||||
- "failed to get adc clock\n");
|
||||
-
|
||||
info->vref = devm_regulator_get(&pdev->dev, "vref");
|
||||
if (IS_ERR(info->vref))
|
||||
return dev_err_probe(&pdev->dev, PTR_ERR(info->vref),
|
||||
@@ -540,31 +516,15 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
|
||||
|
||||
info->uv_vref = ret;
|
||||
|
||||
- ret = clk_prepare_enable(info->pclk);
|
||||
- if (ret < 0) {
|
||||
- dev_err(&pdev->dev, "failed to enable pclk\n");
|
||||
- return ret;
|
||||
- }
|
||||
- ret = devm_add_action_or_reset(&pdev->dev,
|
||||
- rockchip_saradc_pclk_disable, info);
|
||||
- if (ret) {
|
||||
- dev_err(&pdev->dev, "failed to register devm action, %d\n",
|
||||
- ret);
|
||||
- return ret;
|
||||
- }
|
||||
+ info->pclk = devm_clk_get_enabled(&pdev->dev, "apb_pclk");
|
||||
+ if (IS_ERR(info->pclk))
|
||||
+ return dev_err_probe(&pdev->dev, PTR_ERR(info->pclk),
|
||||
+ "failed to get pclk\n");
|
||||
|
||||
- ret = clk_prepare_enable(info->clk);
|
||||
- if (ret < 0) {
|
||||
- dev_err(&pdev->dev, "failed to enable converter clock\n");
|
||||
- return ret;
|
||||
- }
|
||||
- ret = devm_add_action_or_reset(&pdev->dev,
|
||||
- rockchip_saradc_clk_disable, info);
|
||||
- if (ret) {
|
||||
- dev_err(&pdev->dev, "failed to register devm action, %d\n",
|
||||
- ret);
|
||||
- return ret;
|
||||
- }
|
||||
+ info->clk = devm_clk_get_enabled(&pdev->dev, "saradc");
|
||||
+ if (IS_ERR(info->clk))
|
||||
+ return dev_err_probe(&pdev->dev, PTR_ERR(info->clk),
|
||||
+ "failed to get adc clock\n");
|
||||
|
||||
platform_set_drvdata(pdev, indio_dev);
|
||||
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 412fdfbbfc17c588c1f9ae3ee838c29860549f8e Mon Sep 17 00:00:00 2001
|
||||
From: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:36 +0530
|
||||
Subject: [PATCH 4/9] iio: adc: rockchip_saradc: Use of_device_get_match_data
|
||||
|
||||
Use of_device_get_match_data() to simplify the code.
|
||||
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
|
||||
---
|
||||
drivers/iio/adc/rockchip_saradc.c | 8 ++++----
|
||||
1 file changed, 4 insertions(+), 4 deletions(-)
|
||||
|
||||
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
|
||||
index ac424ea50787..cbe347fe8df7 100644
|
||||
--- a/drivers/iio/adc/rockchip_saradc.c
|
||||
+++ b/drivers/iio/adc/rockchip_saradc.c
|
||||
@@ -415,10 +415,10 @@ static void rockchip_saradc_regulator_unreg_notifier(void *data)
|
||||
|
||||
static int rockchip_saradc_probe(struct platform_device *pdev)
|
||||
{
|
||||
+ const struct rockchip_saradc_data *match_data;
|
||||
struct rockchip_saradc *info = NULL;
|
||||
struct device_node *np = pdev->dev.of_node;
|
||||
struct iio_dev *indio_dev = NULL;
|
||||
- const struct of_device_id *match;
|
||||
int ret;
|
||||
int irq;
|
||||
|
||||
@@ -432,13 +432,13 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
|
||||
}
|
||||
info = iio_priv(indio_dev);
|
||||
|
||||
- match = of_match_device(rockchip_saradc_match, &pdev->dev);
|
||||
- if (!match) {
|
||||
+ match_data = of_device_get_match_data(&pdev->dev);
|
||||
+ if (!match_data) {
|
||||
dev_err(&pdev->dev, "failed to match device\n");
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
- info->data = match->data;
|
||||
+ info->data = match_data;
|
||||
|
||||
/* Sanity check for possible later IP variants with more channels */
|
||||
if (info->data->num_channels > SARADC_MAX_CHANNELS) {
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 7706b5ab350facf848f44aa846a2d26a8fa64a65 Mon Sep 17 00:00:00 2001
|
||||
From: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:37 +0530
|
||||
Subject: [PATCH 5/9] iio: adc: rockchip_saradc: Match alignment with open
|
||||
parenthesis
|
||||
|
||||
Match alignment with open parenthesis for improving the code
|
||||
readability.
|
||||
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
|
||||
---
|
||||
drivers/iio/adc/rockchip_saradc.c | 5 ++---
|
||||
1 file changed, 2 insertions(+), 3 deletions(-)
|
||||
|
||||
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
|
||||
index cbe347fe8df7..436e219984fd 100644
|
||||
--- a/drivers/iio/adc/rockchip_saradc.c
|
||||
+++ b/drivers/iio/adc/rockchip_saradc.c
|
||||
@@ -151,7 +151,7 @@ static void rockchip_saradc_power_down(struct rockchip_saradc *info)
|
||||
}
|
||||
|
||||
static int rockchip_saradc_conversion(struct rockchip_saradc *info,
|
||||
- struct iio_chan_spec const *chan)
|
||||
+ struct iio_chan_spec const *chan)
|
||||
{
|
||||
reinit_completion(&info->completion);
|
||||
|
||||
@@ -394,8 +394,7 @@ static irqreturn_t rockchip_saradc_trigger_handler(int irq, void *p)
|
||||
}
|
||||
|
||||
static int rockchip_saradc_volt_notify(struct notifier_block *nb,
|
||||
- unsigned long event,
|
||||
- void *data)
|
||||
+ unsigned long event, void *data)
|
||||
{
|
||||
struct rockchip_saradc *info =
|
||||
container_of(nb, struct rockchip_saradc, nb);
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 6511ca5e340de5a0d146d86a705f839ffdeb35ec Mon Sep 17 00:00:00 2001
|
||||
From: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:38 +0530
|
||||
Subject: [PATCH 6/9] iio: adc: rockchip_saradc: Use dev_err_probe
|
||||
|
||||
Use dev_err_probe instead of dev_err in probe function,
|
||||
which simplifies code a little bit and prints the error
|
||||
code.
|
||||
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
---
|
||||
drivers/iio/adc/rockchip_saradc.c | 45 ++++++++++++++-----------------
|
||||
1 file changed, 20 insertions(+), 25 deletions(-)
|
||||
|
||||
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
|
||||
index 436e219984fd..921844d9232d 100644
|
||||
--- a/drivers/iio/adc/rockchip_saradc.c
|
||||
+++ b/drivers/iio/adc/rockchip_saradc.c
|
||||
@@ -425,25 +425,23 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
|
||||
return -ENODEV;
|
||||
|
||||
indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*info));
|
||||
- if (!indio_dev) {
|
||||
- dev_err(&pdev->dev, "failed allocating iio device\n");
|
||||
- return -ENOMEM;
|
||||
- }
|
||||
+ if (!indio_dev)
|
||||
+ return dev_err_probe(&pdev->dev, -ENOMEM,
|
||||
+ "failed allocating iio device\n");
|
||||
+
|
||||
info = iio_priv(indio_dev);
|
||||
|
||||
match_data = of_device_get_match_data(&pdev->dev);
|
||||
- if (!match_data) {
|
||||
- dev_err(&pdev->dev, "failed to match device\n");
|
||||
- return -ENODEV;
|
||||
- }
|
||||
+ if (!match_data)
|
||||
+ return dev_err_probe(&pdev->dev, -ENODEV,
|
||||
+ "failed to match device\n");
|
||||
|
||||
info->data = match_data;
|
||||
|
||||
/* Sanity check for possible later IP variants with more channels */
|
||||
- if (info->data->num_channels > SARADC_MAX_CHANNELS) {
|
||||
- dev_err(&pdev->dev, "max channels exceeded");
|
||||
- return -EINVAL;
|
||||
- }
|
||||
+ if (info->data->num_channels > SARADC_MAX_CHANNELS)
|
||||
+ return dev_err_probe(&pdev->dev, -EINVAL,
|
||||
+ "max channels exceeded");
|
||||
|
||||
info->regs = devm_platform_ioremap_resource(pdev, 0);
|
||||
if (IS_ERR(info->regs))
|
||||
@@ -491,23 +489,20 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
|
||||
* This may become user-configurable in the future.
|
||||
*/
|
||||
ret = clk_set_rate(info->clk, info->data->clk_rate);
|
||||
- if (ret < 0) {
|
||||
- dev_err(&pdev->dev, "failed to set adc clk rate, %d\n", ret);
|
||||
- return ret;
|
||||
- }
|
||||
+ if (ret < 0)
|
||||
+ return dev_err_probe(&pdev->dev, ret,
|
||||
+ "failed to set adc clk rate\n");
|
||||
|
||||
ret = regulator_enable(info->vref);
|
||||
- if (ret < 0) {
|
||||
- dev_err(&pdev->dev, "failed to enable vref regulator\n");
|
||||
- return ret;
|
||||
- }
|
||||
+ if (ret < 0)
|
||||
+ return dev_err_probe(&pdev->dev, ret,
|
||||
+ "failed to enable vref regulator\n");
|
||||
+
|
||||
ret = devm_add_action_or_reset(&pdev->dev,
|
||||
rockchip_saradc_regulator_disable, info);
|
||||
- if (ret) {
|
||||
- dev_err(&pdev->dev, "failed to register devm action, %d\n",
|
||||
- ret);
|
||||
- return ret;
|
||||
- }
|
||||
+ if (ret)
|
||||
+ return dev_err_probe(&pdev->dev, ret,
|
||||
+ "failed to register devm action\n");
|
||||
|
||||
ret = regulator_get_voltage(info->vref);
|
||||
if (ret < 0)
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 97f4513badc89771a4823235dab215078534419a Mon Sep 17 00:00:00 2001
|
||||
From: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:39 +0530
|
||||
Subject: [PATCH 7/9] arm64: dts: rockchip: Add DT node for ADC support in
|
||||
RK3588
|
||||
|
||||
Add DT node for ADC support in RK3588.
|
||||
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 12 ++++++++++++
|
||||
1 file changed, 12 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index 977ed617f59e..e7622a44c9ea 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -1906,6 +1906,18 @@ dmac2: dma-controller@fed10000 {
|
||||
#dma-cells = <1>;
|
||||
};
|
||||
|
||||
+ saradc: saradc@fec10000 {
|
||||
+ compatible = "rockchip,rk3588-saradc";
|
||||
+ reg = <0x0 0xfec10000 0x0 0x10000>;
|
||||
+ interrupts = <GIC_SPI 398 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ #io-channel-cells = <1>;
|
||||
+ clocks = <&cru CLK_SARADC>, <&cru PCLK_SARADC>;
|
||||
+ clock-names = "saradc", "apb_pclk";
|
||||
+ resets = <&cru SRST_P_SARADC>;
|
||||
+ reset-names = "saradc-apb";
|
||||
+ status = "disabled";
|
||||
+ };
|
||||
+
|
||||
system_sram2: sram@ff001000 {
|
||||
compatible = "mmio-sram";
|
||||
reg = <0x0 0xff001000 0x0 0xef000>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From a4bde5a0ce8037f213cb1ede73181c55d108df6a Mon Sep 17 00:00:00 2001
|
||||
From: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Date: Sun, 4 Jun 2023 00:23:40 +0530
|
||||
Subject: [PATCH 8/9] dt-bindings: iio: adc: Add rockchip,rk3588-saradc string
|
||||
|
||||
Add rockchip,rk3588-saradc compatible string.
|
||||
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
|
||||
---
|
||||
Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 1 +
|
||||
1 file changed, 1 insertion(+)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
|
||||
index da50b529c157..11c27ea451c8 100644
|
||||
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
|
||||
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
|
||||
@@ -21,6 +21,7 @@ properties:
|
||||
- rockchip,rk3308-saradc
|
||||
- rockchip,rk3328-saradc
|
||||
- rockchip,rk3568-saradc
|
||||
+ - rockchip,rk3588-saradc
|
||||
- rockchip,rv1108-saradc
|
||||
- rockchip,rv1126-saradc
|
||||
- const: rockchip,rk3399-saradc
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 0bea534abbafa0f8d43fb27c65d9c9d84f3269f3 Mon Sep 17 00:00:00 2001
|
||||
From: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
Date: Sun, 11 Jun 2023 00:56:47 +0530
|
||||
Subject: [PATCH 9/9] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed
|
||||
warning
|
||||
|
||||
rk3588-saradc isn't compatible with the rk3399-saradc variant,
|
||||
hence, fix the following dtbs_check warning for 'oneOf' condition
|
||||
failure.
|
||||
|
||||
DTC_CHK arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb
|
||||
/home/shreeya/linux/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb:
|
||||
saradc@fec10000: compatible: 'oneOf' conditional failed,
|
||||
one must be fixed:
|
||||
['rockchip,rk3588-saradc'] is too short
|
||||
'rockchip,saradc' was expected
|
||||
'rockchip,rk3066-tsadc' was expected
|
||||
'rockchip,rk3399-saradc' was expected
|
||||
|
||||
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
|
||||
---
|
||||
Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
|
||||
index 11c27ea451c8..aa24b841393c 100644
|
||||
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
|
||||
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
|
||||
@@ -15,13 +15,13 @@ properties:
|
||||
- const: rockchip,saradc
|
||||
- const: rockchip,rk3066-tsadc
|
||||
- const: rockchip,rk3399-saradc
|
||||
+ - const: rockchip,rk3588-saradc
|
||||
- items:
|
||||
- enum:
|
||||
- rockchip,px30-saradc
|
||||
- rockchip,rk3308-saradc
|
||||
- rockchip,rk3328-saradc
|
||||
- rockchip,rk3568-saradc
|
||||
- - rockchip,rk3588-saradc
|
||||
- rockchip,rv1108-saradc
|
||||
- rockchip,rv1126-saradc
|
||||
- const: rockchip,rk3399-saradc
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,530 @@
|
||||
From 03b582ba80822d93be46e13ca7121f99c7132da8 Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Mon, 12 Jun 2023 19:13:33 +0200
|
||||
Subject: [PATCH 1/5] dt-bindings: ata: dwc-ahci: add PHY clocks
|
||||
|
||||
Add PHY transmit and receive clocks as described by the
|
||||
DW SATA AHCI HW manual.
|
||||
|
||||
Suggested-by: Serge Semin <fancer.lancer@gmail.com>
|
||||
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
|
||||
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
.../devicetree/bindings/ata/snps,dwc-ahci-common.yaml | 8 ++++++--
|
||||
1 file changed, 6 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml b/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml
|
||||
index c1457910520b..34c5bf65b02d 100644
|
||||
--- a/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml
|
||||
+++ b/Documentation/devicetree/bindings/ata/snps,dwc-ahci-common.yaml
|
||||
@@ -31,11 +31,11 @@ properties:
|
||||
PM-alive clock, RxOOB detection clock, embedded PHYs reference (Rx/Tx)
|
||||
clock, etc.
|
||||
minItems: 1
|
||||
- maxItems: 4
|
||||
+ maxItems: 6
|
||||
|
||||
clock-names:
|
||||
minItems: 1
|
||||
- maxItems: 4
|
||||
+ maxItems: 6
|
||||
items:
|
||||
oneOf:
|
||||
- description: Application APB/AHB/AXI BIU clock
|
||||
@@ -48,6 +48,10 @@ properties:
|
||||
const: pmalive
|
||||
- description: RxOOB detection clock
|
||||
const: rxoob
|
||||
+ - description: PHY Transmit Clock
|
||||
+ const: asic
|
||||
+ - description: PHY Receive Clock
|
||||
+ const: rbc
|
||||
- description: SATA Ports reference clock
|
||||
const: ref
|
||||
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 81b1ff2b1b72caa5ed7776df1547bbddc83395e8 Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Mon, 12 Jun 2023 19:13:34 +0200
|
||||
Subject: [PATCH 2/5] dt-bindings: ata: dwc-ahci: add Rockchip RK3588
|
||||
|
||||
This adds Rockchip RK3588 AHCI binding. In order to narrow down the
|
||||
allowed clocks without bloating the generic binding, the description
|
||||
of Rockchip's AHCI controllers has been moved to its own file.
|
||||
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
|
||||
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
|
||||
---
|
||||
.../bindings/ata/rockchip,dwc-ahci.yaml | 124 ++++++++++++++++++
|
||||
.../bindings/ata/snps,dwc-ahci.yaml | 13 +-
|
||||
2 files changed, 133 insertions(+), 4 deletions(-)
|
||||
create mode 100644 Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
|
||||
new file mode 100644
|
||||
index 000000000000..b5e5767d8698
|
||||
--- /dev/null
|
||||
+++ b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
|
||||
@@ -0,0 +1,124 @@
|
||||
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
|
||||
+%YAML 1.2
|
||||
+---
|
||||
+$id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml#
|
||||
+$schema: http://devicetree.org/meta-schemas/core.yaml#
|
||||
+
|
||||
+title: Synopsys DWC AHCI SATA controller for Rockchip devices
|
||||
+
|
||||
+maintainers:
|
||||
+ - Serge Semin <fancer.lancer@gmail.com>
|
||||
+
|
||||
+description:
|
||||
+ This document defines device tree bindings for the Synopsys DWC
|
||||
+ implementation of the AHCI SATA controller found in Rockchip
|
||||
+ devices.
|
||||
+
|
||||
+select:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ contains:
|
||||
+ enum:
|
||||
+ - rockchip,rk3568-dwc-ahci
|
||||
+ - rockchip,rk3588-dwc-ahci
|
||||
+ required:
|
||||
+ - compatible
|
||||
+
|
||||
+properties:
|
||||
+ compatible:
|
||||
+ items:
|
||||
+ - enum:
|
||||
+ - rockchip,rk3568-dwc-ahci
|
||||
+ - rockchip,rk3588-dwc-ahci
|
||||
+ - const: snps,dwc-ahci
|
||||
+
|
||||
+ ports-implemented:
|
||||
+ const: 1
|
||||
+
|
||||
+ sata-port@0:
|
||||
+ $ref: /schemas/ata/snps,dwc-ahci-common.yaml#/$defs/dwc-ahci-port
|
||||
+
|
||||
+ properties:
|
||||
+ reg:
|
||||
+ const: 0
|
||||
+
|
||||
+ unevaluatedProperties: false
|
||||
+
|
||||
+patternProperties:
|
||||
+ "^sata-port@[1-9a-e]$": false
|
||||
+
|
||||
+required:
|
||||
+ - compatible
|
||||
+ - reg
|
||||
+ - interrupts
|
||||
+ - clocks
|
||||
+ - clock-names
|
||||
+ - ports-implemented
|
||||
+
|
||||
+allOf:
|
||||
+ - $ref: snps,dwc-ahci-common.yaml#
|
||||
+ - if:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ contains:
|
||||
+ enum:
|
||||
+ - rockchip,rk3588-dwc-ahci
|
||||
+ then:
|
||||
+ properties:
|
||||
+ clocks:
|
||||
+ maxItems: 5
|
||||
+ clock-names:
|
||||
+ items:
|
||||
+ - const: sata
|
||||
+ - const: pmalive
|
||||
+ - const: rxoob
|
||||
+ - const: ref
|
||||
+ - const: asic
|
||||
+ - if:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ contains:
|
||||
+ enum:
|
||||
+ - rockchip,rk3568-dwc-ahci
|
||||
+ then:
|
||||
+ properties:
|
||||
+ clocks:
|
||||
+ maxItems: 3
|
||||
+ clock-names:
|
||||
+ items:
|
||||
+ - const: sata
|
||||
+ - const: pmalive
|
||||
+ - const: rxoob
|
||||
+
|
||||
+unevaluatedProperties: false
|
||||
+
|
||||
+examples:
|
||||
+ - |
|
||||
+ #include <dt-bindings/clock/rockchip,rk3588-cru.h>
|
||||
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
|
||||
+ #include <dt-bindings/ata/ahci.h>
|
||||
+ #include <dt-bindings/phy/phy.h>
|
||||
+
|
||||
+ sata@fe210000 {
|
||||
+ compatible = "rockchip,rk3588-dwc-ahci", "snps,dwc-ahci";
|
||||
+ reg = <0xfe210000 0x1000>;
|
||||
+ clocks = <&cru ACLK_SATA0>, <&cru CLK_PMALIVE0>,
|
||||
+ <&cru CLK_RXOOB0>, <&cru CLK_PIPEPHY0_REF>,
|
||||
+ <&cru CLK_PIPEPHY0_PIPE_ASIC_G>;
|
||||
+ clock-names = "sata", "pmalive", "rxoob", "ref", "asic";
|
||||
+ interrupts = <GIC_SPI 273 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ ports-implemented = <0x1>;
|
||||
+ #address-cells = <1>;
|
||||
+ #size-cells = <0>;
|
||||
+
|
||||
+ sata-port@0 {
|
||||
+ reg = <0>;
|
||||
+ hba-port-cap = <HBA_PORT_FBSCP>;
|
||||
+ phys = <&combphy0_ps PHY_TYPE_SATA>;
|
||||
+ phy-names = "sata-phy";
|
||||
+ snps,rx-ts-max = <32>;
|
||||
+ snps,tx-ts-max = <32>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+...
|
||||
diff --git a/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
|
||||
index 5afa4b57ce20..4c848fcb5a5d 100644
|
||||
--- a/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
|
||||
+++ b/Documentation/devicetree/bindings/ata/snps,dwc-ahci.yaml
|
||||
@@ -13,6 +13,15 @@ description:
|
||||
This document defines device tree bindings for the generic Synopsys DWC
|
||||
implementation of the AHCI SATA controller.
|
||||
|
||||
+select:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ enum:
|
||||
+ - snps,dwc-ahci
|
||||
+ - snps,spear-ahci
|
||||
+ required:
|
||||
+ - compatible
|
||||
+
|
||||
allOf:
|
||||
- $ref: snps,dwc-ahci-common.yaml#
|
||||
|
||||
@@ -23,10 +32,6 @@ properties:
|
||||
const: snps,dwc-ahci
|
||||
- description: SPEAr1340 AHCI SATA device
|
||||
const: snps,spear-ahci
|
||||
- - description: Rockhip RK3568 AHCI controller
|
||||
- items:
|
||||
- - const: rockchip,rk3568-dwc-ahci
|
||||
- - const: snps,dwc-ahci
|
||||
|
||||
patternProperties:
|
||||
"^sata-port@[0-9a-e]$":
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 15f3049fcf0e6657c7f4c594b83f4df437a6c03c Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Mon, 12 Jun 2023 19:13:35 +0200
|
||||
Subject: [PATCH 3/5] dt-bindings: phy: rockchip: rk3588 has two reset lines
|
||||
|
||||
The RK3588 has two reset lines for the combphy. One for the
|
||||
APB interface and one for the actual PHY.
|
||||
|
||||
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
.../phy/phy-rockchip-naneng-combphy.yaml | 34 ++++++++++++++++++-
|
||||
1 file changed, 33 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
|
||||
index 9ae514fa7533..d3cd7997879f 100644
|
||||
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
|
||||
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
|
||||
@@ -31,8 +31,14 @@ properties:
|
||||
- const: pipe
|
||||
|
||||
resets:
|
||||
+ minItems: 1
|
||||
+ maxItems: 2
|
||||
+
|
||||
+ reset-names:
|
||||
+ minItems: 1
|
||||
items:
|
||||
- - description: exclusive PHY reset line
|
||||
+ - const: phy
|
||||
+ - const: apb
|
||||
|
||||
rockchip,enable-ssc:
|
||||
type: boolean
|
||||
@@ -78,6 +84,32 @@ required:
|
||||
- rockchip,pipe-phy-grf
|
||||
- "#phy-cells"
|
||||
|
||||
+allOf:
|
||||
+ - if:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ contains:
|
||||
+ const: rockchip,rk3568-naneng-combphy
|
||||
+ then:
|
||||
+ properties:
|
||||
+ resets:
|
||||
+ maxItems: 1
|
||||
+ reset-names:
|
||||
+ maxItems: 1
|
||||
+ - if:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ contains:
|
||||
+ const: rockchip,rk3588-naneng-combphy
|
||||
+ then:
|
||||
+ properties:
|
||||
+ resets:
|
||||
+ minItems: 2
|
||||
+ reset-names:
|
||||
+ minItems: 2
|
||||
+ required:
|
||||
+ - reset-names
|
||||
+
|
||||
additionalProperties: false
|
||||
|
||||
examples:
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 571fb8a07c593ddafa101138ef89d346677cc518 Mon Sep 17 00:00:00 2001
|
||||
From: Muhammed Efe Cetin <efectn@protonmail.com>
|
||||
Date: Tue, 4 Jul 2023 13:11:19 +0300
|
||||
Subject: [PATCH 4/5] arm64: dts: rockchip: rk3588: add combo PHYs
|
||||
|
||||
Add all 3 combo PHYs that can be found in RK3588.
|
||||
They are used for SATA, PCIe or USB3.
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588.dtsi | 21 ++++++++++++
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 42 +++++++++++++++++++++++
|
||||
2 files changed, 63 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588.dtsi b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
index 8be75556af8f..9d8539b5309b 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
@@ -7,6 +7,11 @@
|
||||
#include "rk3588-pinctrl.dtsi"
|
||||
|
||||
/ {
|
||||
+ pipe_phy1_grf: syscon@fd5c0000 {
|
||||
+ compatible = "rockchip,rk3588-pipe-phy-grf", "syscon";
|
||||
+ reg = <0x0 0xfd5c0000 0x0 0x100>;
|
||||
+ };
|
||||
+
|
||||
i2s8_8ch: i2s@fddc8000 {
|
||||
compatible = "rockchip,rk3588-i2s-tdm";
|
||||
reg = <0x0 0xfddc8000 0x0 0x1000>;
|
||||
@@ -123,4 +128,20 @@ gmac0_mtl_tx_setup: tx-queues-config {
|
||||
queue1 {};
|
||||
};
|
||||
};
|
||||
+
|
||||
+ combphy1_ps: phy@fee10000 {
|
||||
+ compatible = "rockchip,rk3588-naneng-combphy";
|
||||
+ reg = <0x0 0xfee10000 0x0 0x100>;
|
||||
+ #phy-cells = <1>;
|
||||
+ clocks = <&cru CLK_REF_PIPE_PHY1>, <&cru PCLK_PCIE_COMBO_PIPE_PHY1>,
|
||||
+ <&cru PCLK_PHP_ROOT>;
|
||||
+ clock-names = "ref", "apb", "pipe";
|
||||
+ assigned-clocks = <&cru CLK_REF_PIPE_PHY1>;
|
||||
+ assigned-clock-rates = <100000000>;
|
||||
+ resets = <&cru SRST_REF_PIPE_PHY1>, <&cru SRST_P_PCIE2_PHY1>;
|
||||
+ reset-names = "phy", "apb";
|
||||
+ rockchip,pipe-grf = <&php_grf>;
|
||||
+ rockchip,pipe-phy-grf = <&pipe_phy1_grf>;
|
||||
+ status = "disabled";
|
||||
+ };
|
||||
};
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index e7622a44c9ea..4aa15ce78365 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -407,6 +407,16 @@ php_grf: syscon@fd5b0000 {
|
||||
reg = <0x0 0xfd5b0000 0x0 0x1000>;
|
||||
};
|
||||
|
||||
+ pipe_phy0_grf: syscon@fd5bc000 {
|
||||
+ compatible = "rockchip,rk3588-pipe-phy-grf", "syscon";
|
||||
+ reg = <0x0 0xfd5bc000 0x0 0x100>;
|
||||
+ };
|
||||
+
|
||||
+ pipe_phy2_grf: syscon@fd5c4000 {
|
||||
+ compatible = "rockchip,rk3588-pipe-phy-grf", "syscon";
|
||||
+ reg = <0x0 0xfd5c4000 0x0 0x100>;
|
||||
+ };
|
||||
+
|
||||
ioc: syscon@fd5f0000 {
|
||||
compatible = "rockchip,rk3588-ioc", "syscon";
|
||||
reg = <0x0 0xfd5f0000 0x0 0x10000>;
|
||||
@@ -1906,6 +1916,38 @@ dmac2: dma-controller@fed10000 {
|
||||
#dma-cells = <1>;
|
||||
};
|
||||
|
||||
+ combphy0_ps: phy@fee00000 {
|
||||
+ compatible = "rockchip,rk3588-naneng-combphy";
|
||||
+ reg = <0x0 0xfee00000 0x0 0x100>;
|
||||
+ #phy-cells = <1>;
|
||||
+ clocks = <&cru CLK_REF_PIPE_PHY0>, <&cru PCLK_PCIE_COMBO_PIPE_PHY0>,
|
||||
+ <&cru PCLK_PHP_ROOT>;
|
||||
+ clock-names = "ref", "apb", "pipe";
|
||||
+ assigned-clocks = <&cru CLK_REF_PIPE_PHY0>;
|
||||
+ assigned-clock-rates = <100000000>;
|
||||
+ resets = <&cru SRST_REF_PIPE_PHY0>, <&cru SRST_P_PCIE2_PHY0>;
|
||||
+ reset-names = "phy", "apb";
|
||||
+ rockchip,pipe-grf = <&php_grf>;
|
||||
+ rockchip,pipe-phy-grf = <&pipe_phy0_grf>;
|
||||
+ status = "disabled";
|
||||
+ };
|
||||
+
|
||||
+ combphy2_psu: phy@fee20000 {
|
||||
+ compatible = "rockchip,rk3588-naneng-combphy";
|
||||
+ reg = <0x0 0xfee20000 0x0 0x100>;
|
||||
+ #phy-cells = <1>;
|
||||
+ clocks = <&cru CLK_REF_PIPE_PHY2>, <&cru PCLK_PCIE_COMBO_PIPE_PHY2>,
|
||||
+ <&cru PCLK_PHP_ROOT>;
|
||||
+ clock-names = "ref", "apb", "pipe";
|
||||
+ assigned-clocks = <&cru CLK_REF_PIPE_PHY2>;
|
||||
+ assigned-clock-rates = <100000000>;
|
||||
+ resets = <&cru SRST_REF_PIPE_PHY2>, <&cru SRST_P_PCIE2_PHY2>;
|
||||
+ reset-names = "phy", "apb";
|
||||
+ rockchip,pipe-grf = <&php_grf>;
|
||||
+ rockchip,pipe-phy-grf = <&pipe_phy2_grf>;
|
||||
+ status = "disabled";
|
||||
+ };
|
||||
+
|
||||
saradc: saradc@fec10000 {
|
||||
compatible = "rockchip,rk3588-saradc";
|
||||
reg = <0x0 0xfec10000 0x0 0x10000>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 95ad8212851df865bb4146278a7bc782bca45880 Mon Sep 17 00:00:00 2001
|
||||
From: Muhammed Efe Cetin <efectn@protonmail.com>
|
||||
Date: Tue, 4 Jul 2023 13:16:57 +0300
|
||||
Subject: [PATCH 5/5] arm64: dts: rockchip: rk3588: add SATA support
|
||||
|
||||
Add all three SATA IP blocks to the RK3588 DT.
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588.dtsi | 23 +++++++++++
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 48 +++++++++++++++++++++++
|
||||
2 files changed, 71 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588.dtsi b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
index 9d8539b5309b..b9508cea34f1 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
@@ -129,6 +129,29 @@ gmac0_mtl_tx_setup: tx-queues-config {
|
||||
};
|
||||
};
|
||||
|
||||
+ sata1: sata@fe220000 {
|
||||
+ compatible = "rockchip,rk3588-dwc-ahci", "snps,dwc-ahci";
|
||||
+ reg = <0 0xfe220000 0 0x1000>;
|
||||
+ clocks = <&cru ACLK_SATA1>, <&cru CLK_PMALIVE1>,
|
||||
+ <&cru CLK_RXOOB1>, <&cru CLK_PIPEPHY1_REF>,
|
||||
+ <&cru CLK_PIPEPHY1_PIPE_ASIC_G>;
|
||||
+ clock-names = "sata", "pmalive", "rxoob", "ref", "asic";
|
||||
+ interrupts = <GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ ports-implemented = <0x1>;
|
||||
+ #address-cells = <1>;
|
||||
+ #size-cells = <0>;
|
||||
+ status = "disabled";
|
||||
+
|
||||
+ sata-port@0 {
|
||||
+ reg = <0>;
|
||||
+ hba-port-cap = <HBA_PORT_FBSCP>;
|
||||
+ phys = <&combphy1_ps PHY_TYPE_SATA>;
|
||||
+ phy-names = "sata-phy";
|
||||
+ snps,rx-ts-max = <32>;
|
||||
+ snps,tx-ts-max = <32>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
combphy1_ps: phy@fee10000 {
|
||||
compatible = "rockchip,rk3588-naneng-combphy";
|
||||
reg = <0x0 0xfee10000 0x0 0x100>;
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index 4aa15ce78365..ee091f0a3ca3 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -8,6 +8,8 @@
|
||||
#include <dt-bindings/interrupt-controller/irq.h>
|
||||
#include <dt-bindings/power/rk3588-power.h>
|
||||
#include <dt-bindings/reset/rockchip,rk3588-cru.h>
|
||||
+#include <dt-bindings/phy/phy.h>
|
||||
+#include <dt-bindings/ata/ahci.h>
|
||||
|
||||
/ {
|
||||
compatible = "rockchip,rk3588";
|
||||
@@ -1180,6 +1182,52 @@ gmac1_mtl_tx_setup: tx-queues-config {
|
||||
};
|
||||
};
|
||||
|
||||
+ sata0: sata@fe210000 {
|
||||
+ compatible = "rockchip,rk3588-dwc-ahci", "snps,dwc-ahci";
|
||||
+ reg = <0 0xfe210000 0 0x1000>;
|
||||
+ clocks = <&cru ACLK_SATA0>, <&cru CLK_PMALIVE0>,
|
||||
+ <&cru CLK_RXOOB0>, <&cru CLK_PIPEPHY0_REF>,
|
||||
+ <&cru CLK_PIPEPHY0_PIPE_ASIC_G>;
|
||||
+ clock-names = "sata", "pmalive", "rxoob", "ref", "asic";
|
||||
+ interrupts = <GIC_SPI 273 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ ports-implemented = <0x1>;
|
||||
+ #address-cells = <1>;
|
||||
+ #size-cells = <0>;
|
||||
+ status = "disabled";
|
||||
+
|
||||
+ sata-port@0 {
|
||||
+ reg = <0>;
|
||||
+ hba-port-cap = <HBA_PORT_FBSCP>;
|
||||
+ phys = <&combphy0_ps PHY_TYPE_SATA>;
|
||||
+ phy-names = "sata-phy";
|
||||
+ snps,rx-ts-max = <32>;
|
||||
+ snps,tx-ts-max = <32>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ sata2: sata@fe230000 {
|
||||
+ compatible = "rockchip,rk3588-dwc-ahci", "snps,dwc-ahci";
|
||||
+ reg = <0 0xfe230000 0 0x1000>;
|
||||
+ clocks = <&cru ACLK_SATA2>, <&cru CLK_PMALIVE2>,
|
||||
+ <&cru CLK_RXOOB2>, <&cru CLK_PIPEPHY2_REF>,
|
||||
+ <&cru CLK_PIPEPHY2_PIPE_ASIC_G>;
|
||||
+ clock-names = "sata", "pmalive", "rxoob", "ref", "asic";
|
||||
+ interrupts = <GIC_SPI 275 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ ports-implemented = <0x1>;
|
||||
+ #address-cells = <1>;
|
||||
+ #size-cells = <0>;
|
||||
+ status = "disabled";
|
||||
+
|
||||
+ sata-port@0 {
|
||||
+ reg = <0>;
|
||||
+ hba-port-cap = <HBA_PORT_FBSCP>;
|
||||
+ phys = <&combphy2_psu PHY_TYPE_SATA>;
|
||||
+ phy-names = "sata-phy";
|
||||
+ snps,rx-ts-max = <32>;
|
||||
+ snps,tx-ts-max = <32>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
sdmmc: mmc@fe2c0000 {
|
||||
compatible = "rockchip,rk3588-dw-mshc", "rockchip,rk3288-dw-mshc";
|
||||
reg = <0x0 0xfe2c0000 0x0 0x4000>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,436 @@
|
||||
From 55f62897ce675d323b81dc92e9ce9060543e61f3 Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Fri, 16 Jun 2023 19:00:19 +0200
|
||||
Subject: [PATCH 1/4] dt-bindings: PCI: dwc: rockchip: Fix interrupt-names
|
||||
issue
|
||||
|
||||
The RK356x (and RK3588) have 5 ganged interrupts. For example the
|
||||
"legacy" interrupt combines "inta/intb/intc/intd" with a register
|
||||
providing the details.
|
||||
|
||||
Currently the binding is not specifying these interrupts resulting
|
||||
in a bunch of errors for all rk356x boards using PCIe.
|
||||
|
||||
Fix this by specifying the interrupts and add them to the example
|
||||
to prevent regressions.
|
||||
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Reviewed-by: Rob Herring <robh@kernel.org>
|
||||
---
|
||||
.../bindings/pci/rockchip-dw-pcie.yaml | 18 ++++++++++++++++++
|
||||
.../devicetree/bindings/pci/snps,dw-pcie.yaml | 15 ++++++++++++++-
|
||||
2 files changed, 32 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
index 24c88942e59e..98e45d2d8dfe 100644
|
||||
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
@@ -56,6 +56,17 @@ properties:
|
||||
- const: pclk
|
||||
- const: aux
|
||||
|
||||
+ interrupts:
|
||||
+ maxItems: 5
|
||||
+
|
||||
+ interrupt-names:
|
||||
+ items:
|
||||
+ - const: sys
|
||||
+ - const: pmc
|
||||
+ - const: msg
|
||||
+ - const: legacy
|
||||
+ - const: err
|
||||
+
|
||||
msi-map: true
|
||||
|
||||
num-lanes: true
|
||||
@@ -98,6 +109,7 @@ unevaluatedProperties: false
|
||||
|
||||
examples:
|
||||
- |
|
||||
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
|
||||
|
||||
bus {
|
||||
#address-cells = <2>;
|
||||
@@ -117,6 +129,12 @@ examples:
|
||||
"aclk_dbi", "pclk",
|
||||
"aux";
|
||||
device_type = "pci";
|
||||
+ interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
|
||||
+ <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>,
|
||||
+ <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>,
|
||||
+ <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
|
||||
+ <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
|
||||
+ interrupt-names = "sys", "pmc", "msg", "legacy", "err";
|
||||
linux,pci-domain = <2>;
|
||||
max-link-speed = <2>;
|
||||
msi-map = <0x2000 &its 0x2000 0x1000>;
|
||||
diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
|
||||
index 1a83f0f65f19..9f605eb297f5 100644
|
||||
--- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
|
||||
+++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
|
||||
@@ -193,9 +193,22 @@ properties:
|
||||
oneOf:
|
||||
- description: See native "app" IRQ for details
|
||||
enum: [ intr ]
|
||||
+ - description: Combined Legacy A/B/C/D interrupt signal.
|
||||
+ const: legacy
|
||||
+ - description: Combined System interrupt signal.
|
||||
+ const: sys
|
||||
+ - description: Combined Power Management interrupt signal.
|
||||
+ const: pmc
|
||||
+ - description: Combined Message Received interrupt signal.
|
||||
+ const: msg
|
||||
+ - description: Combined Error interrupt signal.
|
||||
+ const: err
|
||||
+
|
||||
allOf:
|
||||
- contains:
|
||||
- const: msi
|
||||
+ enum:
|
||||
+ - msi
|
||||
+ - msg
|
||||
|
||||
additionalProperties: true
|
||||
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From ed28eed118bb1815347fbb4ea3e4ebb2a917e2b4 Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Fri, 16 Jun 2023 19:00:20 +0200
|
||||
Subject: [PATCH 2/4] dt-bindings: PCI: dwc: rockchip: Add missing
|
||||
legacy-interrupt-controller
|
||||
|
||||
Rockchip RK356x and RK3588 handle legacy interrupts via a ganged
|
||||
interrupts. The RK356x DT implements this via a sub-node named
|
||||
"legacy-interrupt-controller", just like a couple of other PCIe
|
||||
implementations. This adds proper documentation for this and updates
|
||||
the example to avoid regressions.
|
||||
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Reviewed-by: Rob Herring <robh@kernel.org>
|
||||
---
|
||||
.../bindings/pci/rockchip-dw-pcie.yaml | 24 +++++++++++++++++++
|
||||
1 file changed, 24 insertions(+)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
index 98e45d2d8dfe..bf81d306cc80 100644
|
||||
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
@@ -67,6 +67,22 @@ properties:
|
||||
- const: legacy
|
||||
- const: err
|
||||
|
||||
+ legacy-interrupt-controller:
|
||||
+ description: Interrupt controller node for handling legacy PCI interrupts.
|
||||
+ type: object
|
||||
+ properties:
|
||||
+ "#address-cells":
|
||||
+ const: 0
|
||||
+
|
||||
+ "#interrupt-cells":
|
||||
+ const: 1
|
||||
+
|
||||
+ "interrupt-controller": true
|
||||
+
|
||||
+ interrupts:
|
||||
+ items:
|
||||
+ - description: combined legacy interrupt
|
||||
+
|
||||
msi-map: true
|
||||
|
||||
num-lanes: true
|
||||
@@ -148,6 +164,14 @@ examples:
|
||||
reset-names = "pipe";
|
||||
#address-cells = <3>;
|
||||
#size-cells = <2>;
|
||||
+
|
||||
+ legacy-interrupt-controller {
|
||||
+ interrupt-controller;
|
||||
+ #address-cells = <0>;
|
||||
+ #interrupt-cells = <1>;
|
||||
+ interrupt-parent = <&gic>;
|
||||
+ interrupts = <GIC_SPI 72 IRQ_TYPE_EDGE_RISING>;
|
||||
+ };
|
||||
};
|
||||
};
|
||||
...
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 4298296463a25b9a7830001da790e8240654337a Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Fri, 16 Jun 2023 19:00:21 +0200
|
||||
Subject: [PATCH 3/4] dt-bindings: PCI: dwc: rockchip: Update for RK3588
|
||||
|
||||
The PCIe 2.0 controllers on RK3588 need one additional clock,
|
||||
one additional reset line and one for ranges entry.
|
||||
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Reviewed-by: Rob Herring <robh@kernel.org>
|
||||
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
|
||||
---
|
||||
.../bindings/pci/rockchip-dw-pcie.yaml | 16 +++++++++++++---
|
||||
1 file changed, 13 insertions(+), 3 deletions(-)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
index bf81d306cc80..7897af0ec297 100644
|
||||
--- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
+++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
|
||||
@@ -41,20 +41,24 @@ properties:
|
||||
- const: config
|
||||
|
||||
clocks:
|
||||
+ minItems: 5
|
||||
items:
|
||||
- description: AHB clock for PCIe master
|
||||
- description: AHB clock for PCIe slave
|
||||
- description: AHB clock for PCIe dbi
|
||||
- description: APB clock for PCIe
|
||||
- description: Auxiliary clock for PCIe
|
||||
+ - description: PIPE clock
|
||||
|
||||
clock-names:
|
||||
+ minItems: 5
|
||||
items:
|
||||
- const: aclk_mst
|
||||
- const: aclk_slv
|
||||
- const: aclk_dbi
|
||||
- const: pclk
|
||||
- const: aux
|
||||
+ - const: pipe
|
||||
|
||||
interrupts:
|
||||
maxItems: 5
|
||||
@@ -97,13 +101,19 @@ properties:
|
||||
maxItems: 1
|
||||
|
||||
ranges:
|
||||
- maxItems: 2
|
||||
+ minItems: 2
|
||||
+ maxItems: 3
|
||||
|
||||
resets:
|
||||
- maxItems: 1
|
||||
+ minItems: 1
|
||||
+ maxItems: 2
|
||||
|
||||
reset-names:
|
||||
- const: pipe
|
||||
+ oneOf:
|
||||
+ - const: pipe
|
||||
+ - items:
|
||||
+ - const: pwr
|
||||
+ - const: pipe
|
||||
|
||||
vpcie3v3-supply: true
|
||||
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 83fbcafeea18de93601461ffd14311ea1ef8a433 Mon Sep 17 00:00:00 2001
|
||||
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
Date: Fri, 16 Jun 2023 19:00:22 +0200
|
||||
Subject: [PATCH 4/4] arm64: dts: rockchip: rk3588: add PCIe2 support
|
||||
|
||||
Add all three PCIe2 IP blocks to the RK3588 DT. Note, that RK3588
|
||||
also has two PCIe3 IP blocks, that will be handled separately.
|
||||
|
||||
Co-developed-by: Kever Yang <kever.yang@rock-chips.com>
|
||||
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
|
||||
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588.dtsi | 54 +++++++++++
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 108 ++++++++++++++++++++++
|
||||
2 files changed, 162 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588.dtsi b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
index b9508cea34f1..40fee1367b34 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
|
||||
@@ -80,6 +80,60 @@ i2s10_8ch: i2s@fde00000 {
|
||||
status = "disabled";
|
||||
};
|
||||
|
||||
+ pcie2x1l0: pcie@fe170000 {
|
||||
+ compatible = "rockchip,rk3588-pcie", "rockchip,rk3568-pcie";
|
||||
+ #address-cells = <3>;
|
||||
+ #size-cells = <2>;
|
||||
+ bus-range = <0x20 0x2f>;
|
||||
+ clocks = <&cru ACLK_PCIE_1L0_MSTR>, <&cru ACLK_PCIE_1L0_SLV>,
|
||||
+ <&cru ACLK_PCIE_1L0_DBI>, <&cru PCLK_PCIE_1L0>,
|
||||
+ <&cru CLK_PCIE_AUX2>, <&cru CLK_PCIE1L0_PIPE>;
|
||||
+ clock-names = "aclk_mst", "aclk_slv",
|
||||
+ "aclk_dbi", "pclk",
|
||||
+ "aux", "pipe";
|
||||
+ device_type = "pci";
|
||||
+ interrupts = <GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 242 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 239 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ interrupt-names = "sys", "pmc", "msg", "legacy", "err";
|
||||
+ #interrupt-cells = <1>;
|
||||
+ interrupt-map-mask = <0 0 0 7>;
|
||||
+ interrupt-map = <0 0 0 1 &pcie2x1l0_intc 0>,
|
||||
+ <0 0 0 2 &pcie2x1l0_intc 1>,
|
||||
+ <0 0 0 3 &pcie2x1l0_intc 2>,
|
||||
+ <0 0 0 4 &pcie2x1l0_intc 3>;
|
||||
+ linux,pci-domain = <2>;
|
||||
+ num-ib-windows = <8>;
|
||||
+ num-ob-windows = <8>;
|
||||
+ num-viewport = <4>;
|
||||
+ max-link-speed = <2>;
|
||||
+ msi-map = <0x2000 &its0 0x2000 0x1000>;
|
||||
+ num-lanes = <1>;
|
||||
+ phys = <&combphy1_ps PHY_TYPE_PCIE>;
|
||||
+ phy-names = "pcie-phy";
|
||||
+ power-domains = <&power RK3588_PD_PCIE>;
|
||||
+ ranges = <0x01000000 0x0 0xf2100000 0x0 0xf2100000 0x0 0x00100000>,
|
||||
+ <0x02000000 0x0 0xf2200000 0x0 0xf2200000 0x0 0x00e00000>,
|
||||
+ <0x03000000 0x9 0x80000000 0x9 0x80000000 0x0 0x40000000>;
|
||||
+ reg = <0xa 0x40800000 0x0 0x00400000>,
|
||||
+ <0x0 0xfe170000 0x0 0x00010000>,
|
||||
+ <0x0 0xf2000000 0x0 0x00100000>;
|
||||
+ reg-names = "dbi", "apb", "config";
|
||||
+ resets = <&cru SRST_PCIE2_POWER_UP>, <&cru SRST_P_PCIE2>;
|
||||
+ reset-names = "pwr", "pipe";
|
||||
+ status = "disabled";
|
||||
+
|
||||
+ pcie2x1l0_intc: legacy-interrupt-controller {
|
||||
+ interrupt-controller;
|
||||
+ #address-cells = <0>;
|
||||
+ #interrupt-cells = <1>;
|
||||
+ interrupt-parent = <&gic>;
|
||||
+ interrupts = <GIC_SPI 240 IRQ_TYPE_EDGE_RISING 0>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
gmac0: ethernet@fe1b0000 {
|
||||
compatible = "rockchip,rk3588-gmac", "snps,dwmac-4.20a";
|
||||
reg = <0x0 0xfe1b0000 0x0 0x10000>;
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index ee091f0a3ca3..973fd6e8aa36 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -1133,6 +1133,114 @@ qos_vop_m1: qos@fdf82200 {
|
||||
reg = <0x0 0xfdf82200 0x0 0x20>;
|
||||
};
|
||||
|
||||
+ pcie2x1l1: pcie@fe180000 {
|
||||
+ compatible = "rockchip,rk3588-pcie", "rockchip,rk3568-pcie";
|
||||
+ #address-cells = <3>;
|
||||
+ #size-cells = <2>;
|
||||
+ bus-range = <0x30 0x3f>;
|
||||
+ clocks = <&cru ACLK_PCIE_1L1_MSTR>, <&cru ACLK_PCIE_1L1_SLV>,
|
||||
+ <&cru ACLK_PCIE_1L1_DBI>, <&cru PCLK_PCIE_1L1>,
|
||||
+ <&cru CLK_PCIE_AUX3>, <&cru CLK_PCIE1L1_PIPE>;
|
||||
+ clock-names = "aclk_mst", "aclk_slv",
|
||||
+ "aclk_dbi", "pclk",
|
||||
+ "aux", "pipe";
|
||||
+ device_type = "pci";
|
||||
+ interrupts = <GIC_SPI 248 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ interrupt-names = "sys", "pmc", "msg", "legacy", "err";
|
||||
+ #interrupt-cells = <1>;
|
||||
+ interrupt-map-mask = <0 0 0 7>;
|
||||
+ interrupt-map = <0 0 0 1 &pcie2x1l1_intc 0>,
|
||||
+ <0 0 0 2 &pcie2x1l1_intc 1>,
|
||||
+ <0 0 0 3 &pcie2x1l1_intc 2>,
|
||||
+ <0 0 0 4 &pcie2x1l1_intc 3>;
|
||||
+ linux,pci-domain = <3>;
|
||||
+ num-ib-windows = <8>;
|
||||
+ num-ob-windows = <8>;
|
||||
+ num-viewport = <4>;
|
||||
+ max-link-speed = <2>;
|
||||
+ msi-map = <0x3000 &its0 0x3000 0x1000>;
|
||||
+ num-lanes = <1>;
|
||||
+ phys = <&combphy2_psu PHY_TYPE_PCIE>;
|
||||
+ phy-names = "pcie-phy";
|
||||
+ power-domains = <&power RK3588_PD_PCIE>;
|
||||
+ ranges = <0x01000000 0x0 0xf3100000 0x0 0xf3100000 0x0 0x00100000>,
|
||||
+ <0x02000000 0x0 0xf3200000 0x0 0xf3200000 0x0 0x00e00000>,
|
||||
+ <0x03000000 0x9 0xc0000000 0x9 0xc0000000 0x0 0x40000000>;
|
||||
+ reg = <0xa 0x40c00000 0x0 0x00400000>,
|
||||
+ <0x0 0xfe180000 0x0 0x00010000>,
|
||||
+ <0x0 0xf3000000 0x0 0x00100000>;
|
||||
+ reg-names = "dbi", "apb", "config";
|
||||
+ resets = <&cru SRST_PCIE3_POWER_UP>, <&cru SRST_P_PCIE3>;
|
||||
+ reset-names = "pwr", "pipe";
|
||||
+ status = "disabled";
|
||||
+
|
||||
+ pcie2x1l1_intc: legacy-interrupt-controller {
|
||||
+ interrupt-controller;
|
||||
+ #address-cells = <0>;
|
||||
+ #interrupt-cells = <1>;
|
||||
+ interrupt-parent = <&gic>;
|
||||
+ interrupts = <GIC_SPI 245 IRQ_TYPE_EDGE_RISING 0>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ pcie2x1l2: pcie@fe190000 {
|
||||
+ compatible = "rockchip,rk3588-pcie", "rockchip,rk3568-pcie";
|
||||
+ #address-cells = <3>;
|
||||
+ #size-cells = <2>;
|
||||
+ bus-range = <0x40 0x4f>;
|
||||
+ clocks = <&cru ACLK_PCIE_1L2_MSTR>, <&cru ACLK_PCIE_1L2_SLV>,
|
||||
+ <&cru ACLK_PCIE_1L2_DBI>, <&cru PCLK_PCIE_1L2>,
|
||||
+ <&cru CLK_PCIE_AUX4>, <&cru CLK_PCIE1L2_PIPE>;
|
||||
+ clock-names = "aclk_mst", "aclk_slv",
|
||||
+ "aclk_dbi", "pclk",
|
||||
+ "aux", "pipe";
|
||||
+ device_type = "pci";
|
||||
+ interrupts = <GIC_SPI 253 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH 0>,
|
||||
+ <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ interrupt-names = "sys", "pmc", "msg", "legacy", "err";
|
||||
+ #interrupt-cells = <1>;
|
||||
+ interrupt-map-mask = <0 0 0 7>;
|
||||
+ interrupt-map = <0 0 0 1 &pcie2x1l2_intc 0>,
|
||||
+ <0 0 0 2 &pcie2x1l2_intc 1>,
|
||||
+ <0 0 0 3 &pcie2x1l2_intc 2>,
|
||||
+ <0 0 0 4 &pcie2x1l2_intc 3>;
|
||||
+ linux,pci-domain = <4>;
|
||||
+ num-ib-windows = <8>;
|
||||
+ num-ob-windows = <8>;
|
||||
+ num-viewport = <4>;
|
||||
+ max-link-speed = <2>;
|
||||
+ msi-map = <0x4000 &its0 0x4000 0x1000>;
|
||||
+ num-lanes = <1>;
|
||||
+ phys = <&combphy0_ps PHY_TYPE_PCIE>;
|
||||
+ phy-names = "pcie-phy";
|
||||
+ power-domains = <&power RK3588_PD_PCIE>;
|
||||
+ ranges = <0x01000000 0x0 0xf4100000 0x0 0xf4100000 0x0 0x00100000>,
|
||||
+ <0x02000000 0x0 0xf4200000 0x0 0xf4200000 0x0 0x00e00000>,
|
||||
+ <0x03000000 0xa 0x00000000 0xa 0x00000000 0x0 0x40000000>;
|
||||
+ reg = <0xa 0x41000000 0x0 0x00400000>,
|
||||
+ <0x0 0xfe190000 0x0 0x00010000>,
|
||||
+ <0x0 0xf4000000 0x0 0x00100000>;
|
||||
+ reg-names = "dbi", "apb", "config";
|
||||
+ resets = <&cru SRST_PCIE4_POWER_UP>, <&cru SRST_P_PCIE4>;
|
||||
+ reset-names = "pwr", "pipe";
|
||||
+ status = "disabled";
|
||||
+
|
||||
+ pcie2x1l2_intc: legacy-interrupt-controller {
|
||||
+ interrupt-controller;
|
||||
+ #address-cells = <0>;
|
||||
+ #interrupt-cells = <1>;
|
||||
+ interrupt-parent = <&gic>;
|
||||
+ interrupts = <GIC_SPI 250 IRQ_TYPE_EDGE_RISING 0>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
gmac1: ethernet@fe1c0000 {
|
||||
compatible = "rockchip,rk3588-gmac", "snps,dwmac-4.20a";
|
||||
reg = <0x0 0xfe1c0000 0x0 0x10000>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,847 @@
|
||||
From a71fb1ef5b28f73ef42f4becc2c3fcb944797348 Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:41 +0300
|
||||
Subject: [PATCH 1/9] dt-bindings: nvmem: Convert rockchip-otp.txt to dt-schema
|
||||
|
||||
Convert the Rockchip OTP memory bindings to dt-schema.
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
|
||||
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
|
||||
---
|
||||
.../bindings/nvmem/rockchip,otp.yaml | 82 +++++++++++++++++++
|
||||
.../bindings/nvmem/rockchip-otp.txt | 25 ------
|
||||
2 files changed, 82 insertions(+), 25 deletions(-)
|
||||
create mode 100644 Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
|
||||
delete mode 100644 Documentation/devicetree/bindings/nvmem/rockchip-otp.txt
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
|
||||
new file mode 100644
|
||||
index 000000000000..4cd425ae2823
|
||||
--- /dev/null
|
||||
+++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
|
||||
@@ -0,0 +1,82 @@
|
||||
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
|
||||
+%YAML 1.2
|
||||
+---
|
||||
+$id: http://devicetree.org/schemas/nvmem/rockchip,otp.yaml#
|
||||
+$schema: http://devicetree.org/meta-schemas/core.yaml#
|
||||
+
|
||||
+title: Rockchip internal OTP (One Time Programmable) memory
|
||||
+
|
||||
+maintainers:
|
||||
+ - Heiko Stuebner <heiko@sntech.de>
|
||||
+
|
||||
+allOf:
|
||||
+ - $ref: nvmem.yaml#
|
||||
+
|
||||
+properties:
|
||||
+ compatible:
|
||||
+ enum:
|
||||
+ - rockchip,px30-otp
|
||||
+ - rockchip,rk3308-otp
|
||||
+
|
||||
+ reg:
|
||||
+ maxItems: 1
|
||||
+
|
||||
+ clocks:
|
||||
+ maxItems: 3
|
||||
+
|
||||
+ clock-names:
|
||||
+ items:
|
||||
+ - const: otp
|
||||
+ - const: apb_pclk
|
||||
+ - const: phy
|
||||
+
|
||||
+ resets:
|
||||
+ maxItems: 1
|
||||
+
|
||||
+ reset-names:
|
||||
+ items:
|
||||
+ - const: phy
|
||||
+
|
||||
+required:
|
||||
+ - compatible
|
||||
+ - reg
|
||||
+ - clocks
|
||||
+ - clock-names
|
||||
+ - resets
|
||||
+ - reset-names
|
||||
+
|
||||
+unevaluatedProperties: false
|
||||
+
|
||||
+examples:
|
||||
+ - |
|
||||
+ #include <dt-bindings/clock/px30-cru.h>
|
||||
+
|
||||
+ soc {
|
||||
+ #address-cells = <2>;
|
||||
+ #size-cells = <2>;
|
||||
+
|
||||
+ otp: efuse@ff290000 {
|
||||
+ compatible = "rockchip,px30-otp";
|
||||
+ reg = <0x0 0xff290000 0x0 0x4000>;
|
||||
+ clocks = <&cru SCLK_OTP_USR>, <&cru PCLK_OTP_NS>,
|
||||
+ <&cru PCLK_OTP_PHY>;
|
||||
+ clock-names = "otp", "apb_pclk", "phy";
|
||||
+ resets = <&cru SRST_OTP_PHY>;
|
||||
+ reset-names = "phy";
|
||||
+ #address-cells = <1>;
|
||||
+ #size-cells = <1>;
|
||||
+
|
||||
+ cpu_id: id@7 {
|
||||
+ reg = <0x07 0x10>;
|
||||
+ };
|
||||
+
|
||||
+ cpu_leakage: cpu-leakage@17 {
|
||||
+ reg = <0x17 0x1>;
|
||||
+ };
|
||||
+
|
||||
+ performance: performance@1e {
|
||||
+ reg = <0x1e 0x1>;
|
||||
+ bits = <4 3>;
|
||||
+ };
|
||||
+ };
|
||||
+ };
|
||||
diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-otp.txt b/Documentation/devicetree/bindings/nvmem/rockchip-otp.txt
|
||||
deleted file mode 100644
|
||||
index 40f649f7c2e5..000000000000
|
||||
--- a/Documentation/devicetree/bindings/nvmem/rockchip-otp.txt
|
||||
+++ /dev/null
|
||||
@@ -1,25 +0,0 @@
|
||||
-Rockchip internal OTP (One Time Programmable) memory device tree bindings
|
||||
-
|
||||
-Required properties:
|
||||
-- compatible: Should be one of the following.
|
||||
- - "rockchip,px30-otp" - for PX30 SoCs.
|
||||
- - "rockchip,rk3308-otp" - for RK3308 SoCs.
|
||||
-- reg: Should contain the registers location and size
|
||||
-- clocks: Must contain an entry for each entry in clock-names.
|
||||
-- clock-names: Should be "otp", "apb_pclk" and "phy".
|
||||
-- resets: Must contain an entry for each entry in reset-names.
|
||||
- See ../../reset/reset.txt for details.
|
||||
-- reset-names: Should be "phy".
|
||||
-
|
||||
-See nvmem.txt for more information.
|
||||
-
|
||||
-Example:
|
||||
- otp: otp@ff290000 {
|
||||
- compatible = "rockchip,px30-otp";
|
||||
- reg = <0x0 0xff290000 0x0 0x4000>;
|
||||
- #address-cells = <1>;
|
||||
- #size-cells = <1>;
|
||||
- clocks = <&cru SCLK_OTP_USR>, <&cru PCLK_OTP_NS>,
|
||||
- <&cru PCLK_OTP_PHY>;
|
||||
- clock-names = "otp", "apb_pclk", "phy";
|
||||
- };
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 3282bc8fec63200ed6a3c485bb39b3c094117209 Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:42 +0300
|
||||
Subject: [PATCH 2/9] dt-bindings: nvmem: rockchip,otp: Add compatible for
|
||||
RK3588
|
||||
|
||||
Document the OTP memory found on Rockchip RK3588 SoC.
|
||||
|
||||
Since RK3588 uses different clocks & resets configurations than PX30 /
|
||||
RK3308, provide the required changes in the binding to be able to handle
|
||||
both variants.
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
|
||||
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
|
||||
---
|
||||
.../bindings/nvmem/rockchip,otp.yaml | 54 ++++++++++++++++---
|
||||
1 file changed, 47 insertions(+), 7 deletions(-)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
|
||||
index 4cd425ae2823..9c6eff788928 100644
|
||||
--- a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
|
||||
+++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
|
||||
@@ -9,33 +9,35 @@ title: Rockchip internal OTP (One Time Programmable) memory
|
||||
maintainers:
|
||||
- Heiko Stuebner <heiko@sntech.de>
|
||||
|
||||
-allOf:
|
||||
- - $ref: nvmem.yaml#
|
||||
-
|
||||
properties:
|
||||
compatible:
|
||||
enum:
|
||||
- rockchip,px30-otp
|
||||
- rockchip,rk3308-otp
|
||||
+ - rockchip,rk3588-otp
|
||||
|
||||
reg:
|
||||
maxItems: 1
|
||||
|
||||
clocks:
|
||||
- maxItems: 3
|
||||
+ minItems: 3
|
||||
+ maxItems: 4
|
||||
|
||||
clock-names:
|
||||
+ minItems: 3
|
||||
items:
|
||||
- const: otp
|
||||
- const: apb_pclk
|
||||
- const: phy
|
||||
+ - const: arb
|
||||
|
||||
resets:
|
||||
- maxItems: 1
|
||||
+ minItems: 1
|
||||
+ maxItems: 3
|
||||
|
||||
reset-names:
|
||||
- items:
|
||||
- - const: phy
|
||||
+ minItems: 1
|
||||
+ maxItems: 3
|
||||
|
||||
required:
|
||||
- compatible
|
||||
@@ -45,6 +47,44 @@ required:
|
||||
- resets
|
||||
- reset-names
|
||||
|
||||
+allOf:
|
||||
+ - $ref: nvmem.yaml#
|
||||
+
|
||||
+ - if:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ contains:
|
||||
+ enum:
|
||||
+ - rockchip,px30-otp
|
||||
+ - rockchip,rk3308-otp
|
||||
+ then:
|
||||
+ properties:
|
||||
+ clocks:
|
||||
+ maxItems: 3
|
||||
+ resets:
|
||||
+ maxItems: 1
|
||||
+ reset-names:
|
||||
+ items:
|
||||
+ - const: phy
|
||||
+
|
||||
+ - if:
|
||||
+ properties:
|
||||
+ compatible:
|
||||
+ contains:
|
||||
+ enum:
|
||||
+ - rockchip,rk3588-otp
|
||||
+ then:
|
||||
+ properties:
|
||||
+ clocks:
|
||||
+ minItems: 4
|
||||
+ resets:
|
||||
+ minItems: 3
|
||||
+ reset-names:
|
||||
+ items:
|
||||
+ - const: otp
|
||||
+ - const: apb
|
||||
+ - const: arb
|
||||
+
|
||||
unevaluatedProperties: false
|
||||
|
||||
examples:
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From e4131e9dc168176bf647116e998f34e53cf7233f Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:43 +0300
|
||||
Subject: [PATCH 3/9] nvmem: rockchip-otp: Add clks and reg_read to
|
||||
rockchip_data
|
||||
|
||||
In preparation to support new Rockchip OTP memory devices with different
|
||||
clock configurations and register layout, extend rockchip_data struct
|
||||
with the related members: clks, num_clks, reg_read.
|
||||
|
||||
Additionally, to avoid managing redundant driver data, drop num_clks
|
||||
member from rockchip_otp struct and update all references to point to
|
||||
the equivalent member in rockchip_data.
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
|
||||
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
|
||||
---
|
||||
drivers/nvmem/rockchip-otp.c | 79 ++++++++++++++++++++++--------------
|
||||
1 file changed, 49 insertions(+), 30 deletions(-)
|
||||
|
||||
diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
|
||||
index 9f53bcce2f87..b5a84b379da4 100644
|
||||
--- a/drivers/nvmem/rockchip-otp.c
|
||||
+++ b/drivers/nvmem/rockchip-otp.c
|
||||
@@ -54,21 +54,19 @@
|
||||
|
||||
#define OTPC_TIMEOUT 10000
|
||||
|
||||
+struct rockchip_data {
|
||||
+ int size;
|
||||
+ const char * const *clks;
|
||||
+ int num_clks;
|
||||
+ nvmem_reg_read_t reg_read;
|
||||
+};
|
||||
+
|
||||
struct rockchip_otp {
|
||||
struct device *dev;
|
||||
void __iomem *base;
|
||||
- struct clk_bulk_data *clks;
|
||||
- int num_clks;
|
||||
+ struct clk_bulk_data *clks;
|
||||
struct reset_control *rst;
|
||||
-};
|
||||
-
|
||||
-/* list of required clocks */
|
||||
-static const char * const rockchip_otp_clocks[] = {
|
||||
- "otp", "apb_pclk", "phy",
|
||||
-};
|
||||
-
|
||||
-struct rockchip_data {
|
||||
- int size;
|
||||
+ const struct rockchip_data *data;
|
||||
};
|
||||
|
||||
static int rockchip_otp_reset(struct rockchip_otp *otp)
|
||||
@@ -132,29 +130,23 @@ static int rockchip_otp_ecc_enable(struct rockchip_otp *otp, bool enable)
|
||||
return ret;
|
||||
}
|
||||
|
||||
-static int rockchip_otp_read(void *context, unsigned int offset,
|
||||
- void *val, size_t bytes)
|
||||
+static int px30_otp_read(void *context, unsigned int offset,
|
||||
+ void *val, size_t bytes)
|
||||
{
|
||||
struct rockchip_otp *otp = context;
|
||||
u8 *buf = val;
|
||||
- int ret = 0;
|
||||
-
|
||||
- ret = clk_bulk_prepare_enable(otp->num_clks, otp->clks);
|
||||
- if (ret < 0) {
|
||||
- dev_err(otp->dev, "failed to prepare/enable clks\n");
|
||||
- return ret;
|
||||
- }
|
||||
+ int ret;
|
||||
|
||||
ret = rockchip_otp_reset(otp);
|
||||
if (ret) {
|
||||
dev_err(otp->dev, "failed to reset otp phy\n");
|
||||
- goto disable_clks;
|
||||
+ return ret;
|
||||
}
|
||||
|
||||
ret = rockchip_otp_ecc_enable(otp, false);
|
||||
if (ret < 0) {
|
||||
dev_err(otp->dev, "rockchip_otp_ecc_enable err\n");
|
||||
- goto disable_clks;
|
||||
+ return ret;
|
||||
}
|
||||
|
||||
writel(OTPC_USE_USER | OTPC_USE_USER_MASK, otp->base + OTPC_USER_CTRL);
|
||||
@@ -174,8 +166,28 @@ static int rockchip_otp_read(void *context, unsigned int offset,
|
||||
|
||||
read_end:
|
||||
writel(0x0 | OTPC_USE_USER_MASK, otp->base + OTPC_USER_CTRL);
|
||||
-disable_clks:
|
||||
- clk_bulk_disable_unprepare(otp->num_clks, otp->clks);
|
||||
+
|
||||
+ return ret;
|
||||
+}
|
||||
+
|
||||
+static int rockchip_otp_read(void *context, unsigned int offset,
|
||||
+ void *val, size_t bytes)
|
||||
+{
|
||||
+ struct rockchip_otp *otp = context;
|
||||
+ int ret;
|
||||
+
|
||||
+ if (!otp->data || !otp->data->reg_read)
|
||||
+ return -EINVAL;
|
||||
+
|
||||
+ ret = clk_bulk_prepare_enable(otp->data->num_clks, otp->clks);
|
||||
+ if (ret < 0) {
|
||||
+ dev_err(otp->dev, "failed to prepare/enable clks\n");
|
||||
+ return ret;
|
||||
+ }
|
||||
+
|
||||
+ ret = otp->data->reg_read(context, offset, val, bytes);
|
||||
+
|
||||
+ clk_bulk_disable_unprepare(otp->data->num_clks, otp->clks);
|
||||
|
||||
return ret;
|
||||
}
|
||||
@@ -189,8 +201,15 @@ static struct nvmem_config otp_config = {
|
||||
.reg_read = rockchip_otp_read,
|
||||
};
|
||||
|
||||
+static const char * const px30_otp_clocks[] = {
|
||||
+ "otp", "apb_pclk", "phy",
|
||||
+};
|
||||
+
|
||||
static const struct rockchip_data px30_data = {
|
||||
.size = 0x40,
|
||||
+ .clks = px30_otp_clocks,
|
||||
+ .num_clks = ARRAY_SIZE(px30_otp_clocks),
|
||||
+ .reg_read = px30_otp_read,
|
||||
};
|
||||
|
||||
static const struct of_device_id rockchip_otp_match[] = {
|
||||
@@ -225,21 +244,21 @@ static int rockchip_otp_probe(struct platform_device *pdev)
|
||||
if (!otp)
|
||||
return -ENOMEM;
|
||||
|
||||
+ otp->data = data;
|
||||
otp->dev = dev;
|
||||
otp->base = devm_platform_ioremap_resource(pdev, 0);
|
||||
if (IS_ERR(otp->base))
|
||||
return PTR_ERR(otp->base);
|
||||
|
||||
- otp->num_clks = ARRAY_SIZE(rockchip_otp_clocks);
|
||||
- otp->clks = devm_kcalloc(dev, otp->num_clks,
|
||||
- sizeof(*otp->clks), GFP_KERNEL);
|
||||
+ otp->clks = devm_kcalloc(dev, data->num_clks, sizeof(*otp->clks),
|
||||
+ GFP_KERNEL);
|
||||
if (!otp->clks)
|
||||
return -ENOMEM;
|
||||
|
||||
- for (i = 0; i < otp->num_clks; ++i)
|
||||
- otp->clks[i].id = rockchip_otp_clocks[i];
|
||||
+ for (i = 0; i < data->num_clks; ++i)
|
||||
+ otp->clks[i].id = data->clks[i];
|
||||
|
||||
- ret = devm_clk_bulk_get(dev, otp->num_clks, otp->clks);
|
||||
+ ret = devm_clk_bulk_get(dev, data->num_clks, otp->clks);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From a0cad270a253d54eaea3643f9d8426dbb436ec2c Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:44 +0300
|
||||
Subject: [PATCH 4/9] nvmem: rockchip-otp: Generalize
|
||||
rockchip_otp_wait_status()
|
||||
|
||||
In preparation to support additional Rockchip OTP memory devices with
|
||||
different register layout, generalize rockchip_otp_wait_status() to
|
||||
accept a new parameter for specifying the offset of the status register.
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
|
||||
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
|
||||
---
|
||||
drivers/nvmem/rockchip-otp.c | 11 ++++++-----
|
||||
1 file changed, 6 insertions(+), 5 deletions(-)
|
||||
|
||||
diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
|
||||
index b5a84b379da4..b62e001f9116 100644
|
||||
--- a/drivers/nvmem/rockchip-otp.c
|
||||
+++ b/drivers/nvmem/rockchip-otp.c
|
||||
@@ -90,18 +90,19 @@ static int rockchip_otp_reset(struct rockchip_otp *otp)
|
||||
return 0;
|
||||
}
|
||||
|
||||
-static int rockchip_otp_wait_status(struct rockchip_otp *otp, u32 flag)
|
||||
+static int rockchip_otp_wait_status(struct rockchip_otp *otp,
|
||||
+ unsigned int reg, u32 flag)
|
||||
{
|
||||
u32 status = 0;
|
||||
int ret;
|
||||
|
||||
- ret = readl_poll_timeout_atomic(otp->base + OTPC_INT_STATUS, status,
|
||||
+ ret = readl_poll_timeout_atomic(otp->base + reg, status,
|
||||
(status & flag), 1, OTPC_TIMEOUT);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
/* clean int status */
|
||||
- writel(flag, otp->base + OTPC_INT_STATUS);
|
||||
+ writel(flag, otp->base + reg);
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -123,7 +124,7 @@ static int rockchip_otp_ecc_enable(struct rockchip_otp *otp, bool enable)
|
||||
|
||||
writel(SBPI_ENABLE_MASK | SBPI_ENABLE, otp->base + OTPC_SBPI_CTRL);
|
||||
|
||||
- ret = rockchip_otp_wait_status(otp, OTPC_SBPI_DONE);
|
||||
+ ret = rockchip_otp_wait_status(otp, OTPC_INT_STATUS, OTPC_SBPI_DONE);
|
||||
if (ret < 0)
|
||||
dev_err(otp->dev, "timeout during ecc_enable\n");
|
||||
|
||||
@@ -156,7 +157,7 @@ static int px30_otp_read(void *context, unsigned int offset,
|
||||
otp->base + OTPC_USER_ADDR);
|
||||
writel(OTPC_USER_FSM_ENABLE | OTPC_USER_FSM_ENABLE_MASK,
|
||||
otp->base + OTPC_USER_ENABLE);
|
||||
- ret = rockchip_otp_wait_status(otp, OTPC_USER_DONE);
|
||||
+ ret = rockchip_otp_wait_status(otp, OTPC_INT_STATUS, OTPC_USER_DONE);
|
||||
if (ret < 0) {
|
||||
dev_err(otp->dev, "timeout during read setup\n");
|
||||
goto read_end;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From f993ae18db25b7033c4453225d4063775048d9e0 Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:45 +0300
|
||||
Subject: [PATCH 5/9] nvmem: rockchip-otp: Use
|
||||
devm_reset_control_array_get_exclusive()
|
||||
|
||||
In preparation to support new Rockchip OTP memory devices having
|
||||
specific reset configurations, switch devm_reset_control_get() to
|
||||
devm_reset_control_array_get_exclusive().
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
|
||||
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
|
||||
---
|
||||
drivers/nvmem/rockchip-otp.c | 2 +-
|
||||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||||
|
||||
diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
|
||||
index b62e001f9116..439aea1f8874 100644
|
||||
--- a/drivers/nvmem/rockchip-otp.c
|
||||
+++ b/drivers/nvmem/rockchip-otp.c
|
||||
@@ -263,7 +263,7 @@ static int rockchip_otp_probe(struct platform_device *pdev)
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
- otp->rst = devm_reset_control_get(dev, "phy");
|
||||
+ otp->rst = devm_reset_control_array_get_exclusive(dev);
|
||||
if (IS_ERR(otp->rst))
|
||||
return PTR_ERR(otp->rst);
|
||||
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 1db5714fc59aa0b0b829155493389429cc497ddb Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:46 +0300
|
||||
Subject: [PATCH 6/9] nvmem: rockchip-otp: Improve probe error handling
|
||||
|
||||
Enhance error handling in the probe function by making use of
|
||||
dev_err_probe(), which ensures the error code is always printed, in
|
||||
addition to the specified error message.
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
|
||||
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
|
||||
---
|
||||
drivers/nvmem/rockchip-otp.c | 21 ++++++++++++---------
|
||||
1 file changed, 12 insertions(+), 9 deletions(-)
|
||||
|
||||
diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
|
||||
index 439aea1f8874..84bf956cc4e1 100644
|
||||
--- a/drivers/nvmem/rockchip-otp.c
|
||||
+++ b/drivers/nvmem/rockchip-otp.c
|
||||
@@ -235,10 +235,8 @@ static int rockchip_otp_probe(struct platform_device *pdev)
|
||||
int ret, i;
|
||||
|
||||
data = of_device_get_match_data(dev);
|
||||
- if (!data) {
|
||||
- dev_err(dev, "failed to get match data\n");
|
||||
- return -EINVAL;
|
||||
- }
|
||||
+ if (!data)
|
||||
+ return dev_err_probe(dev, -EINVAL, "failed to get match data\n");
|
||||
|
||||
otp = devm_kzalloc(&pdev->dev, sizeof(struct rockchip_otp),
|
||||
GFP_KERNEL);
|
||||
@@ -249,7 +247,8 @@ static int rockchip_otp_probe(struct platform_device *pdev)
|
||||
otp->dev = dev;
|
||||
otp->base = devm_platform_ioremap_resource(pdev, 0);
|
||||
if (IS_ERR(otp->base))
|
||||
- return PTR_ERR(otp->base);
|
||||
+ return dev_err_probe(dev, PTR_ERR(otp->base),
|
||||
+ "failed to ioremap resource\n");
|
||||
|
||||
otp->clks = devm_kcalloc(dev, data->num_clks, sizeof(*otp->clks),
|
||||
GFP_KERNEL);
|
||||
@@ -261,18 +260,22 @@ static int rockchip_otp_probe(struct platform_device *pdev)
|
||||
|
||||
ret = devm_clk_bulk_get(dev, data->num_clks, otp->clks);
|
||||
if (ret)
|
||||
- return ret;
|
||||
+ return dev_err_probe(dev, ret, "failed to get clocks\n");
|
||||
|
||||
otp->rst = devm_reset_control_array_get_exclusive(dev);
|
||||
if (IS_ERR(otp->rst))
|
||||
- return PTR_ERR(otp->rst);
|
||||
+ return dev_err_probe(dev, PTR_ERR(otp->rst),
|
||||
+ "failed to get resets\n");
|
||||
|
||||
otp_config.size = data->size;
|
||||
otp_config.priv = otp;
|
||||
otp_config.dev = dev;
|
||||
- nvmem = devm_nvmem_register(dev, &otp_config);
|
||||
|
||||
- return PTR_ERR_OR_ZERO(nvmem);
|
||||
+ nvmem = devm_nvmem_register(dev, &otp_config);
|
||||
+ if (IS_ERR(nvmem))
|
||||
+ return dev_err_probe(dev, PTR_ERR(nvmem),
|
||||
+ "failed to register nvmem device\n");
|
||||
+ return 0;
|
||||
}
|
||||
|
||||
static struct platform_driver rockchip_otp_driver = {
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From a3266c7a0d896cd793a070b18fd456c9dfcf48f6 Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:47 +0300
|
||||
Subject: [PATCH 7/9] nvmem: rockchip-otp: Add support for RK3588
|
||||
|
||||
Add support for the OTP memory device found on the Rockchip RK3588 SoC.
|
||||
|
||||
While here, remove the unnecessary 'void *' casts in the OF device ID
|
||||
table.
|
||||
|
||||
Co-developed-by: Finley Xiao <finley.xiao@rock-chips.com>
|
||||
Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
|
||||
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
|
||||
---
|
||||
drivers/nvmem/rockchip-otp.c | 78 +++++++++++++++++++++++++++++++++++-
|
||||
1 file changed, 76 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/drivers/nvmem/rockchip-otp.c b/drivers/nvmem/rockchip-otp.c
|
||||
index 84bf956cc4e1..cb9aa5428350 100644
|
||||
--- a/drivers/nvmem/rockchip-otp.c
|
||||
+++ b/drivers/nvmem/rockchip-otp.c
|
||||
@@ -54,6 +54,19 @@
|
||||
|
||||
#define OTPC_TIMEOUT 10000
|
||||
|
||||
+/* RK3588 Register */
|
||||
+#define RK3588_OTPC_AUTO_CTRL 0x04
|
||||
+#define RK3588_OTPC_AUTO_EN 0x08
|
||||
+#define RK3588_OTPC_INT_ST 0x84
|
||||
+#define RK3588_OTPC_DOUT0 0x20
|
||||
+#define RK3588_NO_SECURE_OFFSET 0x300
|
||||
+#define RK3588_NBYTES 4
|
||||
+#define RK3588_BURST_NUM 1
|
||||
+#define RK3588_BURST_SHIFT 8
|
||||
+#define RK3588_ADDR_SHIFT 16
|
||||
+#define RK3588_AUTO_EN BIT(0)
|
||||
+#define RK3588_RD_DONE BIT(1)
|
||||
+
|
||||
struct rockchip_data {
|
||||
int size;
|
||||
const char * const *clks;
|
||||
@@ -171,6 +184,52 @@ static int px30_otp_read(void *context, unsigned int offset,
|
||||
return ret;
|
||||
}
|
||||
|
||||
+static int rk3588_otp_read(void *context, unsigned int offset,
|
||||
+ void *val, size_t bytes)
|
||||
+{
|
||||
+ struct rockchip_otp *otp = context;
|
||||
+ unsigned int addr_start, addr_end, addr_len;
|
||||
+ int ret, i = 0;
|
||||
+ u32 data;
|
||||
+ u8 *buf;
|
||||
+
|
||||
+ addr_start = round_down(offset, RK3588_NBYTES) / RK3588_NBYTES;
|
||||
+ addr_end = round_up(offset + bytes, RK3588_NBYTES) / RK3588_NBYTES;
|
||||
+ addr_len = addr_end - addr_start;
|
||||
+ addr_start += RK3588_NO_SECURE_OFFSET;
|
||||
+
|
||||
+ buf = kzalloc(array_size(addr_len, RK3588_NBYTES), GFP_KERNEL);
|
||||
+ if (!buf)
|
||||
+ return -ENOMEM;
|
||||
+
|
||||
+ while (addr_len--) {
|
||||
+ writel((addr_start << RK3588_ADDR_SHIFT) |
|
||||
+ (RK3588_BURST_NUM << RK3588_BURST_SHIFT),
|
||||
+ otp->base + RK3588_OTPC_AUTO_CTRL);
|
||||
+ writel(RK3588_AUTO_EN, otp->base + RK3588_OTPC_AUTO_EN);
|
||||
+
|
||||
+ ret = rockchip_otp_wait_status(otp, RK3588_OTPC_INT_ST,
|
||||
+ RK3588_RD_DONE);
|
||||
+ if (ret < 0) {
|
||||
+ dev_err(otp->dev, "timeout during read setup\n");
|
||||
+ goto read_end;
|
||||
+ }
|
||||
+
|
||||
+ data = readl(otp->base + RK3588_OTPC_DOUT0);
|
||||
+ memcpy(&buf[i], &data, RK3588_NBYTES);
|
||||
+
|
||||
+ i += RK3588_NBYTES;
|
||||
+ addr_start++;
|
||||
+ }
|
||||
+
|
||||
+ memcpy(val, buf + offset % RK3588_NBYTES, bytes);
|
||||
+
|
||||
+read_end:
|
||||
+ kfree(buf);
|
||||
+
|
||||
+ return ret;
|
||||
+}
|
||||
+
|
||||
static int rockchip_otp_read(void *context, unsigned int offset,
|
||||
void *val, size_t bytes)
|
||||
{
|
||||
@@ -213,14 +272,29 @@ static const struct rockchip_data px30_data = {
|
||||
.reg_read = px30_otp_read,
|
||||
};
|
||||
|
||||
+static const char * const rk3588_otp_clocks[] = {
|
||||
+ "otp", "apb_pclk", "phy", "arb",
|
||||
+};
|
||||
+
|
||||
+static const struct rockchip_data rk3588_data = {
|
||||
+ .size = 0x400,
|
||||
+ .clks = rk3588_otp_clocks,
|
||||
+ .num_clks = ARRAY_SIZE(rk3588_otp_clocks),
|
||||
+ .reg_read = rk3588_otp_read,
|
||||
+};
|
||||
+
|
||||
static const struct of_device_id rockchip_otp_match[] = {
|
||||
{
|
||||
.compatible = "rockchip,px30-otp",
|
||||
- .data = (void *)&px30_data,
|
||||
+ .data = &px30_data,
|
||||
},
|
||||
{
|
||||
.compatible = "rockchip,rk3308-otp",
|
||||
- .data = (void *)&px30_data,
|
||||
+ .data = &px30_data,
|
||||
+ },
|
||||
+ {
|
||||
+ .compatible = "rockchip,rk3588-otp",
|
||||
+ .data = &rk3588_data,
|
||||
},
|
||||
{ /* sentinel */ },
|
||||
};
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 4e3178487898d3e21deb144dfa967b4f8c71c8f3 Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Thu, 4 May 2023 23:06:48 +0300
|
||||
Subject: [PATCH 8/9] arm64: dts: rockchip: Add rk3588 OTP node
|
||||
|
||||
Add DT node for Rockchip RK3588/RK3588S OTP memory.
|
||||
|
||||
Co-developed-by: Finley Xiao <finley.xiao@rock-chips.com>
|
||||
Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Tested-by: Vincent Legoll <vincent.legoll@gmail.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 54 +++++++++++++++++++++++
|
||||
1 file changed, 54 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index 7b93abd8f65c..977ed617f59e 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -1841,6 +1841,60 @@ spi4: spi@fecb0000 {
|
||||
status = "disabled";
|
||||
};
|
||||
|
||||
+ otp: efuse@fecc0000 {
|
||||
+ compatible = "rockchip,rk3588-otp";
|
||||
+ reg = <0x0 0xfecc0000 0x0 0x400>;
|
||||
+ clocks = <&cru CLK_OTPC_NS>, <&cru PCLK_OTPC_NS>,
|
||||
+ <&cru CLK_OTP_PHY_G>, <&cru CLK_OTPC_ARB>;
|
||||
+ clock-names = "otp", "apb_pclk", "phy", "arb";
|
||||
+ resets = <&cru SRST_OTPC_NS>, <&cru SRST_P_OTPC_NS>,
|
||||
+ <&cru SRST_OTPC_ARB>;
|
||||
+ reset-names = "otp", "apb", "arb";
|
||||
+ #address-cells = <1>;
|
||||
+ #size-cells = <1>;
|
||||
+
|
||||
+ cpu_code: cpu-code@2 {
|
||||
+ reg = <0x02 0x2>;
|
||||
+ };
|
||||
+
|
||||
+ otp_id: id@7 {
|
||||
+ reg = <0x07 0x10>;
|
||||
+ };
|
||||
+
|
||||
+ otp_cpu_version: cpu-version@1c {
|
||||
+ reg = <0x1c 0x1>;
|
||||
+ bits = <3 3>;
|
||||
+ };
|
||||
+
|
||||
+ cpub0_leakage: cpu-leakage@17 {
|
||||
+ reg = <0x17 0x1>;
|
||||
+ };
|
||||
+
|
||||
+ cpub1_leakage: cpu-leakage@18 {
|
||||
+ reg = <0x18 0x1>;
|
||||
+ };
|
||||
+
|
||||
+ cpul_leakage: cpu-leakage@19 {
|
||||
+ reg = <0x19 0x1>;
|
||||
+ };
|
||||
+
|
||||
+ log_leakage: log-leakage@1a {
|
||||
+ reg = <0x1a 0x1>;
|
||||
+ };
|
||||
+
|
||||
+ gpu_leakage: gpu-leakage@1b {
|
||||
+ reg = <0x1b 0x1>;
|
||||
+ };
|
||||
+
|
||||
+ npu_leakage: npu-leakage@28 {
|
||||
+ reg = <0x28 0x1>;
|
||||
+ };
|
||||
+
|
||||
+ codec_leakage: codec-leakage@29 {
|
||||
+ reg = <0x29 0x1>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
dmac2: dma-controller@fed10000 {
|
||||
compatible = "arm,pl330", "arm,primecell";
|
||||
reg = <0x0 0xfed10000 0x0 0x4000>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 39e135bbe54da0a6ddf98d183c0b4f3f248b17b1 Mon Sep 17 00:00:00 2001
|
||||
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
Date: Sun, 4 Jun 2023 20:13:45 +0300
|
||||
Subject: [PATCH 9/9] arm64: defconfig: Enable Rockchip OTP memory driver
|
||||
|
||||
The Rockchip one-time programmable memory driver provides access to
|
||||
various SoC specific information, e.g. leakage currents of the
|
||||
CPU/GPU/NPU components found on a RK3588 SoC.
|
||||
|
||||
Enable the driver as built-in to allow client device drivers (e.g.
|
||||
cpufreq) to access the required data for proper settings adjustment.
|
||||
|
||||
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
|
||||
---
|
||||
arch/arm64/configs/defconfig | 1 +
|
||||
1 file changed, 1 insertion(+)
|
||||
|
||||
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
|
||||
index a24609e14d50..6ef220d383d3 100644
|
||||
--- a/arch/arm64/configs/defconfig
|
||||
+++ b/arch/arm64/configs/defconfig
|
||||
@@ -1385,6 +1385,7 @@ CONFIG_NVMEM_MTK_EFUSE=y
|
||||
CONFIG_NVMEM_QCOM_QFPROM=y
|
||||
CONFIG_NVMEM_RMEM=m
|
||||
CONFIG_NVMEM_ROCKCHIP_EFUSE=y
|
||||
+CONFIG_NVMEM_ROCKCHIP_OTP=y
|
||||
CONFIG_NVMEM_SNVS_LPGPR=y
|
||||
CONFIG_NVMEM_SPMI_SDAM=m
|
||||
CONFIG_NVMEM_SUNXI_SID=y
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,33 @@
|
||||
From 2ca760c84e3764248233fe8891133f811d16aa2e Mon Sep 17 00:00:00 2001
|
||||
From: Lucas Tanure <lucas.tanure@collabora.com>
|
||||
Date: Thu, 23 Mar 2023 12:27:19 +0000
|
||||
Subject: [PATCH] arm64: defconfig: Enable ethernet for Rock 5B
|
||||
|
||||
Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
|
||||
---
|
||||
arch/arm64/configs/defconfig | 2 ++
|
||||
1 file changed, 2 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
|
||||
index 0777bcae9104b..2982169691f31 100644
|
||||
--- a/arch/arm64/configs/defconfig
|
||||
+++ b/arch/arm64/configs/defconfig
|
||||
@@ -221,6 +221,7 @@ CONFIG_PCIE_ALTERA=y
|
||||
CONFIG_PCIE_ALTERA_MSI=y
|
||||
CONFIG_PCI_HOST_THUNDER_PEM=y
|
||||
CONFIG_PCI_HOST_THUNDER_ECAM=y
|
||||
+CONFIG_PCIE_ROCKCHIP_DW_HOST=y
|
||||
CONFIG_PCIE_ROCKCHIP_HOST=m
|
||||
CONFIG_PCIE_MEDIATEK_GEN3=m
|
||||
CONFIG_PCIE_BRCMSTB=m
|
||||
@@ -1385,6 +1386,7 @@ CONFIG_PHY_RCAR_GEN3_PCIE=y
|
||||
CONFIG_PHY_RCAR_GEN3_USB2=y
|
||||
CONFIG_PHY_RCAR_GEN3_USB3=m
|
||||
CONFIG_PHY_ROCKCHIP_EMMC=y
|
||||
+CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=y
|
||||
CONFIG_PHY_ROCKCHIP_INNO_HDMI=m
|
||||
CONFIG_PHY_ROCKCHIP_INNO_USB2=y
|
||||
CONFIG_PHY_ROCKCHIP_INNO_DSIDPHY=m
|
||||
--
|
||||
GitLab
|
||||
|
||||
1082
patch/kernel/rockchip-rk3588-edge/0025-Add-RK3588-USB2-Support.patch
Normal file
1082
patch/kernel/rockchip-rk3588-edge/0025-Add-RK3588-USB2-Support.patch
Normal file
File diff suppressed because it is too large
Load Diff
2561
patch/kernel/rockchip-rk3588-edge/0026-Add-RK3588-USB3-Support.patch
Normal file
2561
patch/kernel/rockchip-rk3588-edge/0026-Add-RK3588-USB3-Support.patch
Normal file
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,968 @@
|
||||
From 091209864a90c83e11926cf484dbc4a86c34bcfe Mon Sep 17 00:00:00 2001
|
||||
From: Chris Morgan <macromorgan@hotmail.com>
|
||||
Date: Wed, 31 May 2023 11:12:16 -0500
|
||||
Subject: [PATCH 1/5] arm64: dts: rockchip: add default pinctrl for rk3588 emmc
|
||||
|
||||
Add a default pinctrl definition for the rk3588 emmc.
|
||||
|
||||
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
|
||||
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 3 +++
|
||||
1 file changed, 3 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index a3124bd2e092..03462ae13ac7 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -1196,6 +1196,9 @@ sdhci: mmc@fe2e0000 {
|
||||
<&cru TMCLK_EMMC>;
|
||||
clock-names = "core", "bus", "axi", "block", "timer";
|
||||
max-frequency = <200000000>;
|
||||
+ pinctrl-0 = <&emmc_rstnout>, <&emmc_bus8>, <&emmc_clk>,
|
||||
+ <&emmc_cmd>, <&emmc_data_strobe>;
|
||||
+ pinctrl-names = "default";
|
||||
resets = <&cru SRST_C_EMMC>, <&cru SRST_H_EMMC>,
|
||||
<&cru SRST_A_EMMC>, <&cru SRST_B_EMMC>,
|
||||
<&cru SRST_T_EMMC>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 9ac1b750fa33e5a340eaee65cf1085cad9ede25d Mon Sep 17 00:00:00 2001
|
||||
From: Chris Morgan <macromorgan@hotmail.com>
|
||||
Date: Wed, 31 May 2023 11:12:17 -0500
|
||||
Subject: [PATCH 2/5] arm64: dts: rockchip: Add sdio node to rk3588
|
||||
|
||||
Add SDIO node for rk3588/rk3588s.
|
||||
|
||||
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
|
||||
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 15 +++++++++++++++
|
||||
1 file changed, 15 insertions(+)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index 03462ae13ac7..7b93abd8f65c 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -1185,6 +1185,21 @@ sdmmc: mmc@fe2c0000 {
|
||||
status = "disabled";
|
||||
};
|
||||
|
||||
+ sdio: mmc@fe2d0000 {
|
||||
+ compatible = "rockchip,rk3588-dw-mshc", "rockchip,rk3288-dw-mshc";
|
||||
+ reg = <0x00 0xfe2d0000 0x00 0x4000>;
|
||||
+ interrupts = <GIC_SPI 204 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ clocks = <&cru HCLK_SDIO>, <&cru CCLK_SRC_SDIO>,
|
||||
+ <&cru SCLK_SDIO_DRV>, <&cru SCLK_SDIO_SAMPLE>;
|
||||
+ clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
|
||||
+ fifo-depth = <0x100>;
|
||||
+ max-frequency = <200000000>;
|
||||
+ pinctrl-names = "default";
|
||||
+ pinctrl-0 = <&sdiom1_pins>;
|
||||
+ power-domains = <&power RK3588_PD_SDIO>;
|
||||
+ status = "disabled";
|
||||
+ };
|
||||
+
|
||||
sdhci: mmc@fe2e0000 {
|
||||
compatible = "rockchip,rk3588-dwcmshc";
|
||||
reg = <0x0 0xfe2e0000 0x0 0x10000>;
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 5799db8897382289eb29505050b6940ef5587628 Mon Sep 17 00:00:00 2001
|
||||
From: Chris Morgan <macromorgan@hotmail.com>
|
||||
Date: Wed, 31 May 2023 11:12:18 -0500
|
||||
Subject: [PATCH 3/5] dt-bindings: vendor-prefixes: add Indiedroid
|
||||
|
||||
Indiedroid is a sub-brand of Ameridroid for their line of single board
|
||||
computers.
|
||||
https://indiedroid.us/
|
||||
|
||||
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
|
||||
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
|
||||
---
|
||||
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
|
||||
1 file changed, 2 insertions(+)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
|
||||
index 82d39ab0231b..580f32086d55 100644
|
||||
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
|
||||
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
|
||||
@@ -617,6 +617,8 @@ patternProperties:
|
||||
description: Integrated Micro-Electronics Inc.
|
||||
"^incircuit,.*":
|
||||
description: In-Circuit GmbH
|
||||
+ "^indiedroid,.*":
|
||||
+ description: Indiedroid
|
||||
"^inet-tek,.*":
|
||||
description: Shenzhen iNet Mobile Internet Technology Co., Ltd
|
||||
"^infineon,.*":
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From abebfc368ca4c72ae0f789fb72a62a00fcb417f5 Mon Sep 17 00:00:00 2001
|
||||
From: Chris Morgan <macromorgan@hotmail.com>
|
||||
Date: Wed, 31 May 2023 11:12:19 -0500
|
||||
Subject: [PATCH 4/5] dt-bindings: arm: rockchip: Add Indiedroid Nova
|
||||
|
||||
Add Indiedroid Nova, an rk3588s based single board computer.
|
||||
|
||||
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
|
||||
Acked-by: Conor Dooley <conor.dooley@microchip.com>
|
||||
---
|
||||
Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
|
||||
1 file changed, 5 insertions(+)
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
|
||||
index ec141c937b8b..3c5a204bcd81 100644
|
||||
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
|
||||
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
|
||||
@@ -542,6 +542,11 @@ properties:
|
||||
- khadas,edge-v
|
||||
- const: rockchip,rk3399
|
||||
|
||||
+ - description: Indiedroid Nova SBC
|
||||
+ items:
|
||||
+ - const: indiedroid,nova
|
||||
+ - const: rockchip,rk3588s
|
||||
+
|
||||
- description: Khadas Edge2 series boards
|
||||
items:
|
||||
- const: khadas,edge2
|
||||
--
|
||||
2.41.0
|
||||
|
||||
|
||||
From 6b199a6dfde0f0f521d88b45df884dc3b5743571 Mon Sep 17 00:00:00 2001
|
||||
From: Chris Morgan <macromorgan@hotmail.com>
|
||||
Date: Wed, 31 May 2023 11:12:20 -0500
|
||||
Subject: [PATCH 5/5] arm64: dts: rockchip: Add Indiedroid Nova board
|
||||
|
||||
The Indiedroid Nova is an SBC from a sub-brand of Ameridroid that
|
||||
includes the following hardware:
|
||||
|
||||
- A 40-pin GPIO header
|
||||
- 2 USB-A 3.0 ports
|
||||
- 2 USB-A 2.0 ports
|
||||
- A USB-C 2.0 OTG port (used for USB power delivery)
|
||||
- A USB-C 3.0 port that can do display port output.
|
||||
- A Micro HDMI 2.1 port.
|
||||
- A 1GB ethernet port.
|
||||
- An RT8821CS based WiFi/Bluetooth module.
|
||||
- A user replaceable eMMC module.
|
||||
- An SDMMC card slot.
|
||||
- A MIPI DSI connector.
|
||||
- A MIPI CSI connector.
|
||||
- A 3.5mm TRRS audio jack with microphone input.
|
||||
- An 2 pin socket for an RTC battery.
|
||||
- A 4 pin socket for a debug port.
|
||||
- A power button (connected to PMIC), a reset button (connected to SoC
|
||||
reset), a boot button, and a recovery button (both connected to the
|
||||
ADC).
|
||||
- 4GB, 8GB, or 16GB of system RAM.
|
||||
|
||||
This initial devicetree includes support for the WiFi, bluetooth,
|
||||
analog audio out/in, SDMMC, eMMC, RTC, UART debugging, and has
|
||||
the regulator values from the schematics. ADC, graphics output, GPU,
|
||||
USB, and wired ethernet are still pending additional upstream changes.
|
||||
|
||||
Analog audio will require changes to handle a difference between the
|
||||
requested clock frequency of 12288000 and the actual clock freqency
|
||||
of 12287999 before it will work properly. This will be done in a
|
||||
subsequent patch series.
|
||||
|
||||
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/Makefile | 1 +
|
||||
.../dts/rockchip/rk3588s-indiedroid-nova.dts | 764 ++++++++++++++++++
|
||||
2 files changed, 765 insertions(+)
|
||||
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
|
||||
index 2d585bbb8f3a..99f11db8158d 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/Makefile
|
||||
+++ b/arch/arm64/boot/dts/rockchip/Makefile
|
||||
@@ -94,5 +94,6 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
|
||||
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-io.dtb
|
||||
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
|
||||
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
|
||||
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-indiedroid-nova.dtb
|
||||
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-khadas-edge2.dtb
|
||||
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
|
||||
new file mode 100644
|
||||
index 000000000000..add15cdafe76
|
||||
--- /dev/null
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
|
||||
@@ -0,0 +1,764 @@
|
||||
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
|
||||
+
|
||||
+/dts-v1/;
|
||||
+
|
||||
+#include <dt-bindings/gpio/gpio.h>
|
||||
+#include <dt-bindings/pinctrl/rockchip.h>
|
||||
+#include <dt-bindings/usb/pd.h>
|
||||
+#include "rk3588s.dtsi"
|
||||
+
|
||||
+/ {
|
||||
+ model = "Indiedroid Nova";
|
||||
+ compatible = "indiedroid,nova", "rockchip,rk3588s";
|
||||
+
|
||||
+ aliases {
|
||||
+ mmc0 = &sdhci;
|
||||
+ mmc1 = &sdmmc;
|
||||
+ mmc2 = &sdio;
|
||||
+ serial2 = &uart2;
|
||||
+ };
|
||||
+
|
||||
+ chosen {
|
||||
+ stdout-path = "serial2:1500000n8";
|
||||
+ };
|
||||
+
|
||||
+ sdio_pwrseq: sdio-pwrseq {
|
||||
+ compatible = "mmc-pwrseq-simple";
|
||||
+ clock-names = "ext_clock";
|
||||
+ clocks = <&rtc_hym8563>;
|
||||
+ pinctrl-0 = <&wifi_enable_h>;
|
||||
+ pinctrl-names = "default";
|
||||
+ post-power-on-delay-ms = <200>;
|
||||
+ reset-gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_LOW>;
|
||||
+ };
|
||||
+
|
||||
+ sound {
|
||||
+ compatible = "audio-graph-card";
|
||||
+ label = "rockchip,es8388-codec";
|
||||
+ widgets = "Microphone", "Mic Jack",
|
||||
+ "Headphone", "Headphones";
|
||||
+ routing = "LINPUT2", "Mic Jack",
|
||||
+ "Headphones", "LOUT1",
|
||||
+ "Headphones", "ROUT1";
|
||||
+ dais = <&i2s0_8ch_p0>;
|
||||
+ };
|
||||
+
|
||||
+ vbus5v0_typec: vbus5v0-typec {
|
||||
+ compatible = "regulator-fixed";
|
||||
+ enable-active-high;
|
||||
+ gpio = <&gpio4 RK_PA5 GPIO_ACTIVE_HIGH>;
|
||||
+ pinctrl-0 = <&typec5v_pwren>;
|
||||
+ pinctrl-names = "default";
|
||||
+ regulator-name = "vbus5v0_typec";
|
||||
+ regulator-min-microvolt = <5000000>;
|
||||
+ regulator-max-microvolt = <5000000>;
|
||||
+ vin-supply = <&vcc5v0_usb>;
|
||||
+ };
|
||||
+
|
||||
+ vcc_1v1_nldo_s3: vcc-1v1-nldo-s3 {
|
||||
+ compatible = "regulator-fixed";
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1100000>;
|
||||
+ regulator-min-microvolt = <1100000>;
|
||||
+ regulator-name = "vcc_1v1_nldo_s3";
|
||||
+ vin-supply = <&vcc5v0_sys>;
|
||||
+ };
|
||||
+
|
||||
+ /* Regulator is enabled whenever vcc_1v8_s0 is above 1.6v */
|
||||
+ vcc_3v3_s0: vcc-3v3-s0 {
|
||||
+ compatible = "regulator-fixed";
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <3300000>;
|
||||
+ regulator-min-microvolt = <3300000>;
|
||||
+ regulator-name = "vcc_3v3_s0";
|
||||
+ vin-supply = <&vcc_3v3_s3>;
|
||||
+
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcc5v0_sys: vcc5v0-sys {
|
||||
+ compatible = "regulator-fixed";
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <5000000>;
|
||||
+ regulator-min-microvolt = <5000000>;
|
||||
+ regulator-name = "vcc5v0_sys";
|
||||
+ };
|
||||
+
|
||||
+ vcc5v0_usb: vcc5v0-usb {
|
||||
+ compatible = "regulator-fixed";
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <5000000>;
|
||||
+ regulator-min-microvolt = <5000000>;
|
||||
+ regulator-name = "vcc5v0_usb";
|
||||
+ vin-supply = <&vcc5v0_usbdcin>;
|
||||
+ };
|
||||
+
|
||||
+ vcc5v0_usbdcin: vcc5v0-usbdcin {
|
||||
+ compatible = "regulator-fixed";
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <5000000>;
|
||||
+ regulator-min-microvolt = <5000000>;
|
||||
+ regulator-name = "vcc5v0_usbdcin";
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+&cpu_l0 {
|
||||
+ cpu-supply = <&vdd_cpu_lit_s0>;
|
||||
+};
|
||||
+
|
||||
+&cpu_l1 {
|
||||
+ cpu-supply = <&vdd_cpu_lit_s0>;
|
||||
+};
|
||||
+
|
||||
+&cpu_l2 {
|
||||
+ cpu-supply = <&vdd_cpu_lit_s0>;
|
||||
+};
|
||||
+
|
||||
+&cpu_l3 {
|
||||
+ cpu-supply = <&vdd_cpu_lit_s0>;
|
||||
+};
|
||||
+
|
||||
+&cpu_b0{
|
||||
+ cpu-supply = <&vdd_cpu_big0_s0>;
|
||||
+};
|
||||
+
|
||||
+&cpu_b1{
|
||||
+ cpu-supply = <&vdd_cpu_big0_s0>;
|
||||
+};
|
||||
+
|
||||
+&cpu_b2{
|
||||
+ cpu-supply = <&vdd_cpu_big1_s0>;
|
||||
+};
|
||||
+
|
||||
+&cpu_b3{
|
||||
+ cpu-supply = <&vdd_cpu_big1_s0>;
|
||||
+};
|
||||
+
|
||||
+/*
|
||||
+ * Add labels for each GPIO pin exposed on the 40 pin header. Note that
|
||||
+ * voltage of each GPIO pin could be either 3.3v or 1.8v (as noted by
|
||||
+ * label).
|
||||
+ */
|
||||
+&gpio0 {
|
||||
+ gpio-line-names = /* GPIO0 A0-A7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "",
|
||||
+ /* GPIO0 B0-B7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "",
|
||||
+ /* GPIO0 C0-C7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "",
|
||||
+ /* GPIO0 D0-D7 */
|
||||
+ "HEADER_12_1v8", "", "", "HEADER_24_1v8",
|
||||
+ "", "", "", "";
|
||||
+};
|
||||
+
|
||||
+&gpio1 {
|
||||
+ gpio-line-names = /* GPIO1 A0-A7 */
|
||||
+ "HEADER_27_3v3", "HEADER_28_3v3", "", "",
|
||||
+ "HEADER_29_1v8", "", "HEADER_7_1v8", "",
|
||||
+ /* GPIO1 B0-B7 */
|
||||
+ "", "HEADER_31_1v8", "HEADER_33_1v8", "",
|
||||
+ "HEADER_11_1v8", "HEADER_13_1v8", "", "",
|
||||
+ /* GPIO1 C0-C7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "",
|
||||
+ /* GPIO1 D0-D7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "HEADER_5_3v3", "HEADER_3_3v3";
|
||||
+};
|
||||
+
|
||||
+&gpio3 {
|
||||
+ gpio-line-names = /* GPIO3 A0-A7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "",
|
||||
+ /* GPIO3 B0-B7 */
|
||||
+ "HEADER_16_1v8", "HEADER_18_1v8", "", "",
|
||||
+ "", "", "", "HEADER_19_1v8",
|
||||
+ /* GPIO3 C0-C7 */
|
||||
+ "HEADER_21_1v8", "HEADER_23_1v8", "", "HEADER_26_1v8",
|
||||
+ "HEADER_15_1v8", "HEADER_22_1v8", "", "",
|
||||
+ /* GPIO3 D0-D7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "";
|
||||
+};
|
||||
+
|
||||
+&gpio4 {
|
||||
+ gpio-line-names = /* GPIO4 A0-A7 */
|
||||
+ "", "", "HEADER_37_3v3", "HEADER_32_3v3",
|
||||
+ "HEADER_36_3v3", "", "HEADER_35_3v3", "HEADER_38_3v3",
|
||||
+ /* GPIO4 B0-B7 */
|
||||
+ "", "", "", "HEADER_40_3v3",
|
||||
+ "HEADER_8_3v3", "HEADER_10_3v3", "", "",
|
||||
+ /* GPIO4 C0-C7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "",
|
||||
+ /* GPIO4 D0-D7 */
|
||||
+ "", "", "", "",
|
||||
+ "", "", "", "";
|
||||
+};
|
||||
+
|
||||
+&i2c0 {
|
||||
+ pinctrl-0 = <&i2c0m2_xfer>;
|
||||
+ pinctrl-names = "default";
|
||||
+ status = "okay";
|
||||
+
|
||||
+ vdd_cpu_big0_s0: regulator@42 {
|
||||
+ compatible = "rockchip,rk8602";
|
||||
+ reg = <0x42>;
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1050000>;
|
||||
+ regulator-min-microvolt = <550000>;
|
||||
+ regulator-name = "vdd_cpu_big0_s0";
|
||||
+ regulator-ramp-delay = <2300>;
|
||||
+ fcs,suspend-voltage-selector = <1>;
|
||||
+ vin-supply = <&vcc5v0_sys>;
|
||||
+
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdd_cpu_big1_s0: regulator@43 {
|
||||
+ compatible = "rockchip,rk8603", "rockchip,rk8602";
|
||||
+ reg = <0x43>;
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1050000>;
|
||||
+ regulator-min-microvolt = <550000>;
|
||||
+ regulator-name = "vdd_cpu_big1_s0";
|
||||
+ regulator-ramp-delay = <2300>;
|
||||
+ fcs,suspend-voltage-selector = <1>;
|
||||
+ vin-supply = <&vcc5v0_sys>;
|
||||
+
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+&i2c2 {
|
||||
+ status = "okay";
|
||||
+
|
||||
+ vdd_npu_s0: regulator@42 {
|
||||
+ compatible = "rockchip,rk8602";
|
||||
+ reg = <0x42>;
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <950000>;
|
||||
+ regulator-min-microvolt = <550000>;
|
||||
+ regulator-name = "vdd_npu_s0";
|
||||
+ regulator-ramp-delay = <2300>;
|
||||
+ fcs,suspend-voltage-selector = <1>;
|
||||
+ vin-supply = <&vcc5v0_sys>;
|
||||
+
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+&i2c6 {
|
||||
+ pinctrl-0 = <&i2c6m3_xfer>;
|
||||
+ status = "okay";
|
||||
+
|
||||
+ fusb302: typec-portc@22 {
|
||||
+ compatible = "fcs,fusb302";
|
||||
+ reg = <0x22>;
|
||||
+ interrupt-parent = <&gpio0>;
|
||||
+ interrupts = <RK_PC4 IRQ_TYPE_LEVEL_LOW>;
|
||||
+ pinctrl-0 = <&usbc0_int>;
|
||||
+ pinctrl-names = "default";
|
||||
+ vbus-supply = <&vbus5v0_typec>;
|
||||
+
|
||||
+ connector {
|
||||
+ compatible = "usb-c-connector";
|
||||
+ data-role = "dual";
|
||||
+ label = "USB-C";
|
||||
+ power-role = "dual";
|
||||
+ try-power-role = "sink";
|
||||
+ source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
|
||||
+ sink-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_USB_COMM)>;
|
||||
+ op-sink-microwatt = <1000000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ rtc_hym8563: rtc@51 {
|
||||
+ compatible = "haoyu,hym8563";
|
||||
+ reg = <0x51>;
|
||||
+ #clock-cells = <0>;
|
||||
+ clock-output-names = "hym8563";
|
||||
+ interrupt-parent = <&gpio0>;
|
||||
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
|
||||
+ pinctrl-0 = <&hym8563_int>;
|
||||
+ pinctrl-names = "default";
|
||||
+ wakeup-source;
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+&i2c7 {
|
||||
+ pinctrl-0 = <&i2c7m0_xfer>;
|
||||
+ status = "okay";
|
||||
+
|
||||
+ es8388: audio-codec@11 {
|
||||
+ compatible = "everest,es8388";
|
||||
+ reg = <0x11>;
|
||||
+ assigned-clock-rates = <12288000>;
|
||||
+ assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
|
||||
+ AVDD-supply = <&vcc_3v3_s3>;
|
||||
+ clock-names = "mclk";
|
||||
+ clocks = <&cru I2S0_8CH_MCLKOUT>;
|
||||
+ DVDD-supply = <&vcc_1v8_s3>;
|
||||
+ HPVDD-supply = <&vcc_3v3_s3>;
|
||||
+ PVDD-supply = <&vcc_1v8_s3>;
|
||||
+ #sound-dai-cells = <0>;
|
||||
+
|
||||
+ port {
|
||||
+ es8388_p0_0: endpoint {
|
||||
+ remote-endpoint = <&i2s0_8ch_p0_0>;
|
||||
+ };
|
||||
+ };
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+&i2s0_8ch {
|
||||
+ pinctrl-names = "default";
|
||||
+ pinctrl-0 = <&i2s0_lrck
|
||||
+ &i2s0_mclk
|
||||
+ &i2s0_sclk
|
||||
+ &i2s0_sdi0
|
||||
+ &i2s0_sdo0>;
|
||||
+ status = "okay";
|
||||
+
|
||||
+ i2s0_8ch_p0: port {
|
||||
+ i2s0_8ch_p0_0: endpoint {
|
||||
+ dai-format = "i2s";
|
||||
+ mclk-fs = <256>;
|
||||
+ remote-endpoint = <&es8388_p0_0>;
|
||||
+ };
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+
|
||||
+&pinctrl {
|
||||
+ bluetooth-pins {
|
||||
+ bt_reset: bt-reset {
|
||||
+ rockchip,pins =
|
||||
+ <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
|
||||
+ };
|
||||
+
|
||||
+ bt_wake_dev: bt-wake-dev {
|
||||
+ rockchip,pins =
|
||||
+ <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
|
||||
+ };
|
||||
+
|
||||
+ bt_wake_host: bt-wake-host {
|
||||
+ rockchip,pins =
|
||||
+ <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_down>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ hym8563 {
|
||||
+
|
||||
+ hym8563_int: hym8563-int {
|
||||
+ rockchip,pins =
|
||||
+ <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ sdio-pwrseq {
|
||||
+ wifi_enable_h: wifi-enable-h {
|
||||
+ rockchip,pins =
|
||||
+ <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ usb-typec {
|
||||
+ usbc0_int: usbc0-int {
|
||||
+ rockchip,pins =
|
||||
+ <0 RK_PC4 RK_FUNC_GPIO &pcfg_pull_up>;
|
||||
+ };
|
||||
+
|
||||
+ typec5v_pwren: typec5v-pwren {
|
||||
+ rockchip,pins =
|
||||
+ <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>;
|
||||
+ };
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+/* HS400 modes seemed to cause io errors. */
|
||||
+&sdhci {
|
||||
+ bus-width = <8>;
|
||||
+ no-mmc-hs400;
|
||||
+ no-sd;
|
||||
+ no-sdio;
|
||||
+ non-removable;
|
||||
+ max-frequency = <200000000>;
|
||||
+ vmmc-supply = <&vcc_3v3_s0>;
|
||||
+ vqmmc-supply = <&vcc_1v8_s3>;
|
||||
+ status = "okay";
|
||||
+};
|
||||
+
|
||||
+&sdio {
|
||||
+ bus-width = <4>;
|
||||
+ cap-sd-highspeed;
|
||||
+ cap-sdio-irq;
|
||||
+ disable-wp;
|
||||
+ keep-power-in-suspend;
|
||||
+ max-frequency = <100000000>;
|
||||
+ mmc-pwrseq = <&sdio_pwrseq>;
|
||||
+ no-mmc;
|
||||
+ no-sd;
|
||||
+ non-removable;
|
||||
+ sd-uhs-sdr104;
|
||||
+ vmmc-supply = <&vcc_3v3_s3>;
|
||||
+ vqmmc-supply = <&vcc_1v8_s3>;
|
||||
+ status = "okay";
|
||||
+};
|
||||
+
|
||||
+&sdmmc {
|
||||
+ bus-width = <4>;
|
||||
+ cap-mmc-highspeed;
|
||||
+ cap-sd-highspeed;
|
||||
+ disable-wp;
|
||||
+ max-frequency = <200000000>;
|
||||
+ no-sdio;
|
||||
+ no-mmc;
|
||||
+ sd-uhs-sdr104;
|
||||
+ vmmc-supply = <&vcc_3v3_s3>;
|
||||
+ vqmmc-supply = <&vccio_sd_s0>;
|
||||
+ status = "okay";
|
||||
+};
|
||||
+
|
||||
+&spi2 {
|
||||
+ #address-cells = <1>;
|
||||
+ assigned-clocks = <&cru CLK_SPI2>;
|
||||
+ assigned-clock-rates = <200000000>;
|
||||
+ num-cs = <1>;
|
||||
+ pinctrl-0 = <&spi2m2_pins>, <&spi2m2_cs0>;
|
||||
+ pinctrl-names = "default";
|
||||
+ #size-cells = <0>;
|
||||
+ status = "okay";
|
||||
+
|
||||
+ pmic@0 {
|
||||
+ compatible = "rockchip,rk806";
|
||||
+ reg = <0x0>;
|
||||
+ #gpio-cells = <2>;
|
||||
+ gpio-controller;
|
||||
+ interrupt-parent = <&gpio0>;
|
||||
+ interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
|
||||
+ pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
|
||||
+ <&rk806_dvs2_null>, <&rk806_dvs3_null>;
|
||||
+ pinctrl-names = "default";
|
||||
+ spi-max-frequency = <1000000>;
|
||||
+
|
||||
+ vcc1-supply = <&vcc5v0_sys>;
|
||||
+ vcc2-supply = <&vcc5v0_sys>;
|
||||
+ vcc3-supply = <&vcc5v0_sys>;
|
||||
+ vcc4-supply = <&vcc5v0_sys>;
|
||||
+ vcc5-supply = <&vcc5v0_sys>;
|
||||
+ vcc6-supply = <&vcc5v0_sys>;
|
||||
+ vcc7-supply = <&vcc5v0_sys>;
|
||||
+ vcc8-supply = <&vcc5v0_sys>;
|
||||
+ vcc9-supply = <&vcc5v0_sys>;
|
||||
+ vcc10-supply = <&vcc5v0_sys>;
|
||||
+ vcc11-supply = <&vcc_2v0_pldo_s3>;
|
||||
+ vcc12-supply = <&vcc5v0_sys>;
|
||||
+ vcc13-supply = <&vcc_1v1_nldo_s3>;
|
||||
+ vcc14-supply = <&vcc_1v1_nldo_s3>;
|
||||
+ vcca-supply = <&vcc5v0_sys>;
|
||||
+
|
||||
+ rk806_dvs1_null: dvs1-null-pins {
|
||||
+ pins = "gpio_pwrctrl2";
|
||||
+ function = "pin_fun0";
|
||||
+ };
|
||||
+
|
||||
+ rk806_dvs2_null: dvs2-null-pins {
|
||||
+ pins = "gpio_pwrctrl2";
|
||||
+ function = "pin_fun0";
|
||||
+ };
|
||||
+
|
||||
+ rk806_dvs3_null: dvs3-null-pins {
|
||||
+ pins = "gpio_pwrctrl3";
|
||||
+ function = "pin_fun0";
|
||||
+ };
|
||||
+
|
||||
+ regulators {
|
||||
+ vdd_gpu_s0: dcdc-reg1 {
|
||||
+ regulator-boot-on;
|
||||
+ regulator-enable-ramp-delay = <400>;
|
||||
+ regulator-max-microvolt = <950000>;
|
||||
+ regulator-min-microvolt = <550000>;
|
||||
+ regulator-name = "vdd_gpu_s0";
|
||||
+ regulator-ramp-delay = <12500>;
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdd_cpu_lit_s0: dcdc-reg2 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <950000>;
|
||||
+ regulator-min-microvolt = <550000>;
|
||||
+ regulator-ramp-delay = <12500>;
|
||||
+ regulator-name = "vdd_cpu_lit_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdd_logic_s0: dcdc-reg3 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <750000>;
|
||||
+ regulator-min-microvolt = <675000>;
|
||||
+ regulator-name = "vdd_logic_s0";
|
||||
+ regulator-ramp-delay = <12500>;
|
||||
+ regulator-state-mem {
|
||||
+ regulator-on-in-suspend;
|
||||
+ regulator-suspend-microvolt = <750000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdd_vdenc_s0: dcdc-reg4 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <950000>;
|
||||
+ regulator-min-microvolt = <550000>;
|
||||
+ regulator-name = "vdd_vdenc_s0";
|
||||
+ regulator-ramp-delay = <12500>;
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdd_ddr_s0: dcdc-reg5 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-min-microvolt = <750000>;
|
||||
+ regulator-max-microvolt = <850000>;
|
||||
+ regulator-ramp-delay = <12500>;
|
||||
+ regulator-name = "vdd_ddr_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ regulator-suspend-microvolt = <850000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdd2_ddr_s3: dcdc-reg6 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1100000>;
|
||||
+ regulator-min-microvolt = <1100000>;
|
||||
+ regulator-name = "vdd2_ddr_s3";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-on-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcc_2v0_pldo_s3: dcdc-reg7 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <2000000>;
|
||||
+ regulator-min-microvolt = <2000000>;
|
||||
+ regulator-name = "vdd_2v0_pldo_s3";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-on-in-suspend;
|
||||
+ regulator-suspend-microvolt = <2000000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcc_3v3_s3: dcdc-reg8 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <3300000>;
|
||||
+ regulator-min-microvolt = <3300000>;
|
||||
+ regulator-name = "vcc_3v3_s3";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-on-in-suspend;
|
||||
+ regulator-suspend-microvolt = <3300000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vddq_ddr_s0: dcdc-reg9 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <600000>;
|
||||
+ regulator-min-microvolt = <600000>;
|
||||
+ regulator-name = "vddq_ddr_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcc_1v8_s3: dcdc-reg10 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1800000>;
|
||||
+ regulator-min-microvolt = <1800000>;
|
||||
+ regulator-name = "vcc_1v8_s3";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-on-in-suspend;
|
||||
+ regulator-suspend-microvolt = <1800000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcc_1v8_s0: pldo-reg1 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1800000>;
|
||||
+ regulator-min-microvolt = <1800000>;
|
||||
+ regulator-name = "vcc_1v8_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcca_1v8_s0: pldo-reg2 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1800000>;
|
||||
+ regulator-min-microvolt = <1800000>;
|
||||
+ regulator-name = "vcca_1v8_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ regulator-suspend-microvolt = <1800000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdda_1v2_s0: pldo-reg3 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1200000>;
|
||||
+ regulator-min-microvolt = <1200000>;
|
||||
+ regulator-name = "vdda_1v2_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcca_3v3_s0: pldo-reg4 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <3300000>;
|
||||
+ regulator-min-microvolt = <3300000>;
|
||||
+ regulator-name = "vcca_3v3_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vccio_sd_s0: pldo-reg5 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <3300000>;
|
||||
+ regulator-min-microvolt = <1800000>;
|
||||
+ regulator-name = "vccio_sd_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vcc_1v8_s3_pldo6: pldo-reg6 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <1800000>;
|
||||
+ regulator-min-microvolt = <1800000>;
|
||||
+ regulator-name = "vcc_1v8_s3_pldo6";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-on-in-suspend;
|
||||
+ regulator-suspend-microvolt = <1800000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdd_0v75_s3: nldo-reg1 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <750000>;
|
||||
+ regulator-min-microvolt = <750000>;
|
||||
+ regulator-name = "vdd_0v75_s3";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-on-in-suspend;
|
||||
+ regulator-suspend-microvolt = <750000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdda_ddr_pll_s0: nldo-reg2 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <850000>;
|
||||
+ regulator-min-microvolt = <850000>;
|
||||
+ regulator-name = "vdda_ddr_pll_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ regulator-suspend-microvolt = <850000>;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ avdd_0v75_s0: nldo-reg3 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-max-microvolt = <750000>;
|
||||
+ regulator-min-microvolt = <750000>;
|
||||
+ regulator-name = "avdd_0v75_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ vdda_0v85_s0: nldo-reg4 {
|
||||
+ regulator-always-on;
|
||||
+ regulator-boot-on;
|
||||
+ regulator-min-microvolt = <850000>;
|
||||
+ regulator-max-microvolt = <850000>;
|
||||
+ regulator-name = "vdda_0v85_s0";
|
||||
+ regulator-state-mem {
|
||||
+ regulator-off-in-suspend;
|
||||
+ };
|
||||
+ };
|
||||
+
|
||||
+ /* Schematics show not in use */
|
||||
+ nldo-reg5 {
|
||||
+ };
|
||||
+ };
|
||||
+ };
|
||||
+};
|
||||
+
|
||||
+&tsadc {
|
||||
+ status = "okay";
|
||||
+};
|
||||
+
|
||||
+&uart2 {
|
||||
+ pinctrl-0 = <&uart2m0_xfer>;
|
||||
+ status = "okay";
|
||||
+};
|
||||
+
|
||||
+/* DMA seems to interfere with bluetooth device normal operation. */
|
||||
+&uart9 {
|
||||
+ pinctrl-0 = <&uart9m2_xfer>, <&uart9m2_ctsn>, <&uart9m2_rtsn>;
|
||||
+ pinctrl-names = "default";
|
||||
+ /delete-property/ dma-names;
|
||||
+ /delete-property/ dmas;
|
||||
+ uart-has-rtscts;
|
||||
+ status = "okay";
|
||||
+
|
||||
+ bluetooth {
|
||||
+ compatible = "realtek,rtl8821cs-bt",
|
||||
+ "realtek,rtl8723bs-bt";
|
||||
+ device-wake-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_HIGH>;
|
||||
+ enable-gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
|
||||
+ host-wake-gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
|
||||
+ pinctrl-0 = <&bt_reset>, <&bt_wake_dev>, <&bt_wake_host>;
|
||||
+ pinctrl-names = "default";
|
||||
+ };
|
||||
+};
|
||||
--
|
||||
2.41.0
|
||||
|
||||
@@ -0,0 +1,71 @@
|
||||
From b3fc6dde51efdb4dceb1a2fd81490b15307d5328 Mon Sep 17 00:00:00 2001
|
||||
From: Muhammed Efe Cetin <efectn@protonmail.com>
|
||||
Date: Wed, 5 Jul 2023 00:18:54 +0300
|
||||
Subject: [PATCH 1/1] arm64: dts: rockchip: rk3588: add sfc node
|
||||
|
||||
---
|
||||
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 20 +++++++++++++++++---
|
||||
1 file changed, 17 insertions(+), 3 deletions(-)
|
||||
|
||||
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
index 96fb3a6e0c68..d6dda0e6a5d0 100644
|
||||
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
|
||||
@@ -12,7 +12,7 @@
|
||||
#include <dt-bindings/ata/ahci.h>
|
||||
|
||||
/ {
|
||||
- compatible = "rockchip,rk3588";
|
||||
+ compatible = "rockchip,rk3588s", "rockchip,rk3588";
|
||||
|
||||
interrupt-parent = <&gic>;
|
||||
#address-cells = <2>;
|
||||
@@ -524,6 +524,7 @@ u2phy0: usb2-phy@0 {
|
||||
clock-names = "phyclk";
|
||||
clock-output-names = "usb480m_phy0";
|
||||
#clock-cells = <0>;
|
||||
+ rockchip,usbctrl-grf = <&usb_grf>;
|
||||
status = "disabled";
|
||||
|
||||
u2phy0_otg: otg-port {
|
||||
@@ -1573,7 +1574,7 @@ sdhci: mmc@fe2e0000 {
|
||||
clock-names = "core", "bus", "axi", "block", "timer";
|
||||
max-frequency = <200000000>;
|
||||
pinctrl-0 = <&emmc_rstnout>, <&emmc_bus8>, <&emmc_clk>,
|
||||
- <&emmc_cmd>, <&emmc_data_strobe>;
|
||||
+ <&emmc_cmd>, <&emmc_data_strobe>;
|
||||
pinctrl-names = "default";
|
||||
resets = <&cru SRST_C_EMMC>, <&cru SRST_H_EMMC>,
|
||||
<&cru SRST_A_EMMC>, <&cru SRST_B_EMMC>,
|
||||
@@ -1812,7 +1813,7 @@ timer0: timer@feae0000 {
|
||||
clocks = <&cru PCLK_BUSTIMER0>, <&cru CLK_BUSTIMER0>;
|
||||
clock-names = "pclk", "timer";
|
||||
};
|
||||
-
|
||||
+
|
||||
wdt: watchdog@feaf0000 {
|
||||
compatible = "rockchip,rk3588-wdt", "snps,dw-wdt";
|
||||
reg = <0x0 0xfeaf0000 0x0 0x100>;
|
||||
@@ -2442,6 +2443,19 @@ gpio4: gpio@fec50000 {
|
||||
#interrupt-cells = <2>;
|
||||
};
|
||||
};
|
||||
+
|
||||
+ sfc: spi@fe2b0000 {
|
||||
+ compatible = "rockchip,sfc";
|
||||
+ reg = <0x0 0xfe2b0000 0x0 0x4000>;
|
||||
+ interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_HIGH 0>;
|
||||
+ clocks = <&cru SCLK_SFC>, <&cru HCLK_SFC>;
|
||||
+ clock-names = "clk_sfc", "hclk_sfc";
|
||||
+ assigned-clocks = <&cru SCLK_SFC>;
|
||||
+ assigned-clock-rates = <100000000>;
|
||||
+ #address-cells = <1>;
|
||||
+ #size-cells = <0>;
|
||||
+ status = "disabled";
|
||||
+ };
|
||||
};
|
||||
|
||||
#include "rk3588s-pinctrl.dtsi"
|
||||
--
|
||||
2.41.0
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
1128
patch/kernel/rockchip-rk3588-edge/dt/rk3588s-orangepi-5.dts
Normal file
1128
patch/kernel/rockchip-rk3588-edge/dt/rk3588s-orangepi-5.dts
Normal file
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user