JDM170/build
1
0
Fork 0
mirror of https://github.com/armbian/build synced 2025-09-24 19:47:06 +07:00
Code Issues Packages Projects Releases Wiki Activity

image: sanity check: warn if any deb artifacts' actually-installed version does not match artifact-built version

Browse Source 
- this catches problems with outdated/crazy repos, customize doing stupid things, wrong pinning, etc
This commit is contained in:
Ricardo Pardini
2023-05-23 15:57:29 +02:00
committed by igorpecovnik
parent 14a3ec01d0
commit 940d0e740c
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/functions/main/build-packages.sh
View File

@@ -92,11 +92,13 @@ function main_default_build_packages() {
# Store info about all artifacts in the process, for later use (eg during package installation in distro-agnostic).
declare -g -a image_artifacts_all=()
declare -g -A image_artifacts_packages=()
declare -g -A image_artifacts_packages_version=()
declare -g -A image_artifacts_debs=()
declare one_artifact one_artifact_package
for one_artifact in "${artifacts_to_build[@]}"; do
declare -A artifact_map_packages=()
declare -A artifact_map_debs=()
declare artifact_version
WHAT="${one_artifact}" build_artifact_for_image
@@ -105,11 +107,13 @@ function main_default_build_packages() {
image_artifacts_all+=("${one_artifact_package}")
image_artifacts_packages["${one_artifact_package}"]="${artifact_map_packages[${one_artifact_package}]}"
image_artifacts_debs["${one_artifact_package}"]="${artifact_map_debs[${one_artifact_package}]}"
image_artifacts_packages_version["${artifact_map_packages[${one_artifact_package}]}"]="${artifact_version}"
done
done
debug_dict image_artifacts_packages
debug_dict image_artifacts_debs
debug_dict image_artifacts_packages_version
overlayfs_wrapper "cleanup"
reset_uid_owner "${DEB_STORAGE}"

18
lib/functions/main/rootfs-image.sh
View File

@@ -92,4 +92,22 @@ function build_rootfs_and_image() {
function list_installed_packages() {
display_alert "Recording list of installed packages" "asset log" "debug"
LOG_ASSET="installed_packages.txt" do_with_log_asset chroot_sdcard dpkg --get-selections "| grep -v deinstall | awk '{print \$1}' | cut -f1 -d':'"
# Loop over dict image_artifacts_packages_version (package_name -> package version), and warn if any installed versions don't match.
# This is a sanity check, to make sure that the packages we installed are the ones we expected to install.
# Things that might disrupt this: apt repos containing random versions that are then apt upgraded, forced install, crazy customize, wrong pinning, etc.
declare -g -A image_artifacts_packages_version # global scope, set in main_default_build_packages()
declare pkg_name pkg_wanted_version
for pkg_name in "${!image_artifacts_packages_version[@]}"; do
[[ "${pkg_name}" =~ ^linux-headers ]] && continue # linux-headers is a special case, since its always built with kernel, but not always installed (deb-tar)
pkg_wanted_version="${image_artifacts_packages_version[${pkg_name}]}"
display_alert "Checking installed version of package" "${pkg_name}=${pkg_wanted_version}" "debug"
declare actual_version
actual_version=$(chroot "${SDCARD}" dpkg-query -W -f='${Status} ${Package} ${Version}\n' "${pkg_name}" | grep "install ok installed" | cut -d " " -f 5)
if [[ "${actual_version}" != "${pkg_wanted_version}" ]]; then
display_alert "Installed version of package does not match wanted version. Check for inconsistent repo, customize.sh/hooks, extensions, or upgrades installing wrong version" "${pkg_name} :: actual:'${actual_version}' wanted:'${pkg_wanted_version}'" "warn"
else
display_alert "Image installed package version" "✅ ${pkg_name} = ${actual_version}" "info"
fi
done
}