mirror of
https://github.com/armbian/build
synced 2025-09-24 19:47:06 +07:00
45 lines
1.7 KiB
Diff
45 lines
1.7 KiB
Diff
From 17c5e1ba5c6419ee4ff8bfa3f0c9452e617af548 Mon Sep 17 00:00:00 2001
|
|
From: Andre Przywara <andre.przywara@arm.com>
|
|
Date: Tue, 31 Dec 2024 16:51:03 +0000
|
|
Subject: Revert "mfd: axp20x: Allow multiple regulators"
|
|
|
|
As Chris and Vasily reported, the attempt to support multiple AXP PMICs
|
|
in one system [1] breaks some of the battery and charging functionality
|
|
on devices with AXP PMICs. The reason is that the drivers now fail to get
|
|
the correct IIO channel for the ADC component, as the current code seems
|
|
to rely on the zero-based enumeration of the regulator devices.
|
|
A fix is possible, but not trivial, as it requires some rework in the AXP
|
|
MFD driver, which cannot be fully reviewed or tested in time for the
|
|
6.13 release.
|
|
|
|
So revert this patch for now, to avoid regressions on battery powered
|
|
devices. This patch was really only necessary for devices with two
|
|
PMICs, support for which is not mainline yet anyway, so we don't lose
|
|
any functionality.
|
|
|
|
This reverts commit e37ec32188701efa01455b9be42a392adab06ce4.
|
|
|
|
[1] https://lore.kernel.org/linux-sunxi/20241007001408.27249-4-andre.przywara@arm.com/
|
|
|
|
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
|
|
---
|
|
drivers/mfd/axp20x.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
|
|
index d41c3019123d..94fa7b7100de 100644
|
|
--- a/drivers/mfd/axp20x.c
|
|
+++ b/drivers/mfd/axp20x.c
|
|
@@ -1448,7 +1448,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
|
|
}
|
|
}
|
|
|
|
- ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_AUTO, axp20x->cells,
|
|
+ ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_NONE, axp20x->cells,
|
|
axp20x->nr_cells, NULL, 0, NULL);
|
|
|
|
if (ret) {
|
|
--
|
|
2.35.3
|
|
|