JDM170/build
1
0
Fork 0
mirror of https://github.com/armbian/build synced 2025-09-24 19:47:06 +07:00
Code Issues Packages Projects Releases Wiki Activity

don't use "bright black" ANSI for logging unless we're running under a known-good terminal (eg, iTerm2)

Browse Source 
- giving up on the "bright black" == "gray" thing. There's enough bad default themes out there, and not the first time people (rightfully) complained...
This commit is contained in:
Ricardo Pardini
2023-02-24 22:41:09 -03:00
committed by Igor Pečovnik
parent 36de9b7d08
commit 736fe7ecf4
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/functions/logging/logging.sh
View File

@@ -28,11 +28,11 @@ function logging_init() {
declare -g bright_yellow_color="\e[1;33m" yellow_color="\e[0;33m"
declare -g ansi_reset_color="\e[0m"
declare -g -i logging_section_counter=0 # -i: integer
declare -g tool_color="${gray_color}" # default to gray... (should be ok on terminals)
declare -g tool_color="${normal_color}" # default to normal color.
# @TODO: more terminals might have a bit... impaired... default themes. correct.
if [[ "${TERM}" == "alacritty" ]]; then
declare -g tool_color="${normal_color}"
# A few terminals, like iTerm2, are known to correctly display "bright black" as gray. Use that if available.
if [[ "${ITERM_SHELL_INTEGRATION_INSTALLED:-"No"}" == "Yes" ]]; then
declare -g tool_color="${gray_color}"
fi
if [[ "${CI}" == "true" ]]; then # ... but that is too dark for Github Actions