Merge pull request #6666 from lrusak/qa-checks

Add support for logging and reporting QA Checks
This commit is contained in:
CvH
2022-07-18 12:19:21 +02:00
committed by GitHub
4 changed files with 44 additions and 3 deletions

View File

@@ -150,6 +150,33 @@ build_msg() {
fi
}
print_qa_checks() {
if [ -n "${PKG_NAME}" ]; then
if [ -d "${PKG_QA_CHECKS}" ]; then
for qa_check in ${PKG_QA_CHECKS}/*; do
print_color CLR_WARNING "[QA CHECK] [${PKG_NAME}] [$(basename ${qa_check})]:\n$(cat ${qa_check})\n\n"
done
fi
fi
}
log_qa_check() {
local qa_check_title="${1}"
local qa_check_message="${2}"
if [ -n "${qa_check_title}" -a -n "${qa_check_message}" ]; then
if [ -n "${PKG_NAME}" ]; then
print_color CLR_WARNING "[QA CHECK] [${PKG_NAME}] [${qa_check_title}]:\n${qa_check_message}\n"
mkdir -p "${PKG_QA_CHECKS}"
echo -e "${qa_check_message}" >> ${PKG_QA_CHECKS}/${qa_check_title}
else
print_color CLR_WARNING "[QA CHECK] [general] [${qa_check_title}]:\n${qa_check_message}\n"
mkdir -p "${BUILD}/qa_checks/general"
echo -e "${qa_check_message}" >> ${BUILD}/qa_checks/general/${qa_check_title}
fi
fi
}
# prints a warning if the file slated for removal doesn't exist
# this allows us to continue instead of bailing out with just "rm"
safe_remove() {
@@ -158,10 +185,8 @@ safe_remove() {
for path in "$@" ; do
if [ -e "${path}" -o -L "${path}" ]; then
rm -r "${path}"
elif [ -n "${PKG_NAME}" ]; then
print_color CLR_WARNING "safe_remove: path does not exist: [${PKG_NAME}]: ${path}\n"
else
print_color CLR_WARNING "safe_remove: path does not exist: ${path}\n"
log_qa_check "safe_remove" "path does not exist: ${path}"
fi
done
}
@@ -1256,6 +1281,8 @@ source_package() {
elif [[ "${1}" =~ :init$ ]]; then
PKG_INSTALL="$BUILD/install_init/${PKG_NAME}-${PKG_VERSION}"
fi
PKG_QA_CHECKS="${BUILD}/qa_checks/${PKG_NAME}-${PKG_VERSION}"
fi
build_with_debug && BUILD_WITH_DEBUG="yes" || BUILD_WITH_DEBUG="no"